Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1413945
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 2/4] i2c-smbus: add SMBus Host Notify support |
| Date | 2016-06-05 09:30 +0200 |
| Message-ID | <rGAFr-3Nw-5@gated-at.bofh.it> (permalink) |
| References | <rEOMx-1jV-9@gated-at.bofh.it> <rEOMx-1jV-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
> diff --git a/Documentation/i2c/smbus-protocol b/Documentation/i2c/smbus-protocol
> index 6012b12..4e07848 100644
> --- a/Documentation/i2c/smbus-protocol
> +++ b/Documentation/i2c/smbus-protocol
> @@ -199,6 +199,9 @@ alerting device's address.
>
> [S] [HostAddr] [Wr] A [DevAddr] A [DataLow] A [DataHigh] A [P]
>
> +I2C drivers for devices which can trigger SMBus Host Notify should implement
> +the optional alert() callback.
> +
I'd like a similar "This is implemented the following way in the Linux
kernel:" paragraph here as in the alert section. The item what bus
drivers should do is missing.
> + if (host_notify->pending) {
> + spin_unlock_irqrestore(&host_notify->lock, flags);
> + dev_warn(&adapter->dev, "Host Notify already scheduled.\n");
> + return -EFAULT;
Very minor nit: -EBUSY?
> +#if defined(CONFIG_I2C_SMBUS) || defined(CONFIG_I2C_SMBUS_MODULE)
IS_ENABLED()?
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v7 2/4] i2c-smbus: add SMBus Host Notify support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-05-31 12:10 +0200 Re: [PATCH v7 2/4] i2c-smbus: add SMBus Host Notify support Wolfram Sang <wsa@the-dreams.de> - 2016-06-05 09:30 +0200
csiph-web