Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1413603

Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo

Show all headers | View raw

On 06/02, Bjorn Andersson wrote:
> For dm uarts in pio mode tx data is transferred to the fifo register 4
> bytes at a time, but care is not taken when these 4 bytes spans the end
> of the xmit buffer so the loop might read up to 3 bytes past the buffer
> and then skip the actual data at the beginning of the buffer.
> 
> Fix this by, analogous to the DMA case, make sure the chunk doesn't
> wrap the xmit buffer.
> 
> Fixes: 3a878c430fd6 ("tty: serial: msm: Add TX DMA support")
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: Ivan Ivanov <iivanov.xz@gmail.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: stable@vger.kernel.org
> Reported-by: Frank Rowand <frowand.list@gmail.com>
> Reported-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tty: serial: msm: Don't read off end of tx fifo Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-03 02:50 +0200
  Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo Frank Rowand <frowand.list@gmail.com> - 2016-06-03 06:00 +0200
  Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo Stephen Boyd <sboyd@codeaurora.org> - 2016-06-04 02:10 +0200
  Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo Andy Gross <andy.gross@linaro.org> - 2016-06-05 20:50 +0200

csiph-web