Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1413590

Re: [PATCH] rxrpc: Use pr_<level> and pr_fmt, reduce object size a few KB

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] rxrpc: Use pr_<level> and pr_fmt, reduce object size a few KB
Date 2016-06-04 01:50 +0200
Message-ID <rG70J-1fx-5@gated-at.bofh.it> (permalink)
References <rFGae-1z0-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Joe Perches <joe@perches.com>
Date: Thu,  2 Jun 2016 12:08:52 -0700

> Use the more common kernel logging style and reduce object size.
> 
> The logging message prefix changes from a mixture of
> "RxRPC:" and "RXRPC:" to "af_rxrpc: ".
> 
> $ size net/rxrpc/built-in.o*
>    text	   data	    bss	    dec	    hex	filename
>   64172	   1972	   8304	  74448	  122d0	net/rxrpc/built-in.o.new
>   67512	   1972	   8304	  77788	  12fdc	net/rxrpc/built-in.o.old
> 
> Miscellanea:
> 
> o Consolidate the ASSERT macros to use a single pr_err call with
>   decimal and hexadecimal output and a stringified #OP argument
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Looks good to me, applied, thanks Joe.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] rxrpc: Use pr_<level> and pr_fmt, reduce object size a few KB Joe Perches <joe@perches.com> - 2016-06-02 21:10 +0200
  Re: [PATCH] rxrpc: Use pr_<level> and pr_fmt, reduce object size a  few KB David Miller <davem@davemloft.net> - 2016-06-04 01:50 +0200

csiph-web