[PATCH 3/3] Drivers: hv: don't leak memory in vmbus_establish_gpadl()

From	"K. Y. Srinivasan" <kys@microsoft.com>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] Drivers: hv: don't leak memory in vmbus_establish_gpadl()
Date	2016-06-04 00:30 +0200
Message-ID	<rG5Lj-AU-1@gated-at.bofh.it> (permalink)
References	<rG5Lj-AU-3@gated-at.bofh.it> <rG5Lj-AU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Vitaly Kuznetsov <vkuznets@redhat.com>

In some cases create_gpadl_header() allocates submessages but we never
free them.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/channel.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 2b109e8..a68830c 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -388,7 +388,7 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer,
 	struct vmbus_channel_gpadl_header *gpadlmsg;
 	struct vmbus_channel_gpadl_body *gpadl_body;
 	struct vmbus_channel_msginfo *msginfo = NULL;
-	struct vmbus_channel_msginfo *submsginfo;
+	struct vmbus_channel_msginfo *submsginfo, *tmp;
 	struct list_head *curr;
 	u32 next_gpadl_handle;
 	unsigned long flags;
@@ -445,6 +445,10 @@ cleanup:
 	spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);
 	list_del(&msginfo->msglistentry);
 	spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
+	list_for_each_entry_safe(submsginfo, tmp, &msginfo->submsglist,
+				 msglistentry) {
+		kfree(submsginfo);
+	}
 
 	kfree(msginfo);
 	return ret;
-- 
1.7.4.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3/3] Drivers: hv: don't leak memory in vmbus_establish_gpadl() "K. Y. Srinivasan" <kys@microsoft.com> - 2016-06-04 00:30 +0200

csiph-web