Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1413490

Re: [PATCH 3/3] sched/debug: remove unnecessary CONFIG_SCHEDSTATS checks

From Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/3] sched/debug: remove unnecessary CONFIG_SCHEDSTATS checks
Date 2016-06-03 23:20 +0200
Message-ID <rG4Fz-8oJ-9@gated-at.bofh.it> (permalink)
References <rG4cy-7ZV-5@gated-at.bofh.it> <rG4cy-7ZV-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jun 03, 2016 at 03:44:41PM -0500, Josh Poimboeuf wrote:
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3447,7 +3447,7 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
>  
>  	update_stats_curr_start(cfs_rq, se);
>  	cfs_rq->curr = se;
> -#ifdef CONFIG_SCHEDSTATS
> +
>  	/*
>  	 * Track our maximum slice length, if the CPU's load is at
>  	 * least twice that of our own weight (i.e. dont track it
> @@ -3457,7 +3457,7 @@ set_next_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
>  		se->statistics.slice_max = max(se->statistics.slice_max,
>  			se->sum_exec_runtime - se->prev_sum_exec_runtime);
>  	}
> -#endif
> +
>  	se->prev_sum_exec_runtime = se->sum_exec_runtime;

Oops.  This part fails to build without CONFIG_SCHEDSTATS.  This hunk
can just be removed from the patch.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] sched/debug: schedstats bug fix and cleanups Josh Poimboeuf <jpoimboe@redhat.com> - 2016-06-03 22:50 +0200
  [PATCH 2/3] sched/debug: always show nr_migrations Josh Poimboeuf <jpoimboe@redhat.com> - 2016-06-03 22:50 +0200
  [PATCH 1/3] sched/debug: fix /proc/sched_debug regression Josh Poimboeuf <jpoimboe@redhat.com> - 2016-06-03 22:50 +0200
  [PATCH 3/3] sched/debug: remove unnecessary CONFIG_SCHEDSTATS checks Josh Poimboeuf <jpoimboe@redhat.com> - 2016-06-03 22:50 +0200
    Re: [PATCH 3/3] sched/debug: remove unnecessary CONFIG_SCHEDSTATS  checks Josh Poimboeuf <jpoimboe@redhat.com> - 2016-06-03 23:20 +0200
  Re: [PATCH 0/3] sched/debug: schedstats bug fix and cleanups Josh Poimboeuf <jpoimboe@redhat.com> - 2016-06-03 23:50 +0200

csiph-web