Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1413372

Re: [PATCH] drm: sun4i: fix LPAE warnings

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Jun 03, 2016 at 05:57:31PM +0100, Andre Przywara wrote:
> When the sun4i DRM driver is compiled with LPAE enabled, dma_addr_t turns
> into a 64-bit type, which causes warnings with some debug printks:
> =================
> In file included from
> drivers/gpu/drm/sun4i/sun4i_backend.c:13::
> drivers/gpu/drm/sun4i/sun4i_backend.c: In function 'sun4i_backend_update_layer_buffer':
> drivers/gpu/drm/sun4i/sun4i_backend.c:193:19: warning:
> format '%x' expects argument of type 'unsigned int', but argument 3 has
> type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
>   DRM_DEBUG_DRIVER("Using GEM @ 0x%x\n", gem->paddr);
>                    ^
> include/drm/drmP.h:207:34: note: in definition of macro
> 'DRM_DEBUG_DRIVER'
>     drm_ut_debug_printk(__func__, fmt, ##args); \
> .....
> 
> Use the proper printk format specifier [1] for dma_addr_t which takes
> care of those differences.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> [1] Documentation/printk-formats.txt
> ---
>  drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm: sun4i: fix LPAE warnings Andre Przywara <andre.przywara@arm.com> - 2016-06-03 19:00 +0200
  Re: [PATCH] drm: sun4i: fix LPAE warnings Thierry Reding <thierry.reding@gmail.com> - 2016-06-03 19:30 +0200
  Re: [PATCH] drm: sun4i: fix LPAE warnings Arnd Bergmann <arnd@arndb.de> - 2016-06-07 00:40 +0200

csiph-web