Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak
Date	2016-06-02 13:50 +0200
Message-ID	<rFzip-5oX-23@gated-at.bofh.it> (permalink)
References	<rFbJ7-7eG-3@gated-at.bofh.it> <rFbJ7-7eG-21@gated-at.bofh.it> <rFyFJ-5bR-31@gated-at.bofh.it> <rFyZ3-5ib-5@gated-at.bofh.it> <rFz8J-5lj-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02-06-16, 21:37, Michael Ellerman wrote:
> On Thu, 2016-06-02 at 16:52 +0530, Viresh Kumar wrote:
> > On 02-06-16, 21:08, Michael Ellerman wrote:
> > > On Wed, 2016-06-01 at 16:04 +0530, Viresh Kumar wrote:
> > > 
> > > > The policy is copied (unnecessarily) and is never freed. Fix it by just
> > > > getting a reference to the existing policy structure and putting it
> > > > back.
> > > > 
> > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > 
> > > When was it broken, always?
> > > 
> > > Cc: stable ?
> > 
> > Its a small memory leak and its not that we will fail on something. So
> > didn't bother to add those details, but in case they are required:
> > 
> > Cc: <stable@vger.kernel.org> # 4.3+
> > Fixes: 227942809b52 ("cpufreq: powernv: Restore cpu frequency to policy->cur on unthrottling")
> 
> OK. I can't actually see where the copy is?
> 
> But if we are leaking even a small amount of memory in a loop like that, in a
> function that's run semi-regularly, then it's going to add up eventually.

Urg, it wasn't a memory leak actually. I misread.

I somehow thought that cpufreq_get_policy() is also allocating memory
for the policy, but it just memcpy's it into the callers buffer. So,
that's not a problem really.

This patch should be just dropped. Sorry for the noise.

-- 
viresh

Thread

[PATCH 3/8] cpufreq: powerenv: Fix memory leak Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-01 12:40 +0200
  Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak Michael Ellerman <mpe@ellerman.id.au> - 2016-06-02 13:10 +0200
    Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 13:30 +0200
      Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak Michael Ellerman <mpe@ellerman.id.au> - 2016-06-02 13:40 +0200
        Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 13:50 +0200
          Re: [PATCH 3/8] cpufreq: powerenv: Fix memory leak Michael Ellerman <mpe@ellerman.id.au> - 2016-06-02 14:10 +0200

csiph-web