Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1412174

Re: [PATCH 2/4] perf stat: Add computation of TopDown formulas

Show all headers | View raw

Andi,  I am talking about the if statement.  I don't know why it would
happen that nothing got measured.  I am guessing you saw it happen.
May be we can add a comment in the patch that it is possible that all
counter values are zero and therefore we need that if statement.

--
Nilay

On 1 June 2016 at 09:56, Andi Kleen <ak@linux.intel.com> wrote:
> On Wed, Jun 01, 2016 at 09:50:07AM -0500, Nilay Vaish wrote:
>> On 24 May 2016 at 14:52, Andi Kleen <andi@firstfloor.org> wrote:
>> > +static double td_be_bound(int ctx, int cpu)
>> > +{
>> > +       double sum = (td_fe_bound(ctx, cpu) +
>> > +                     td_bad_spec(ctx, cpu) +
>> > +                     td_retiring(ctx, cpu));
>> > +       if (sum == 0)
>> > +               return 0;
>> > +       return sanitize_val(1.0 - sum);
>> > +}
>> > +
>>
>> Can you explain why we need the check on sum?
>
> You mean the if statement?
>
> Otherwise if nothing was measured it would always report everything backend bound,
> which wouldn't be correct.
>
> -Andi
>
> --
> ak@linux.intel.com -- Speaking for myself only

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/4] perf stat: Add computation of TopDown formulas Nilay Vaish <nilayvaish@gmail.com> - 2016-06-01 17:00 +0200
  Re: [PATCH 2/4] perf stat: Add computation of TopDown formulas Andi Kleen <ak@linux.intel.com> - 2016-06-01 17:00 +0200
    Re: [PATCH 2/4] perf stat: Add computation of TopDown formulas Nilay Vaish <nilayvaish@gmail.com> - 2016-06-02 14:10 +0200
      Re: [PATCH 2/4] perf stat: Add computation of TopDown formulas Andi Kleen <andi@firstfloor.org> - 2016-06-02 16:30 +0200

csiph-web