Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1412097

Applied "ASoC: cs53l30: Check return value of regcache_sync()" to the asoc tree

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Applied "ASoC: cs53l30: Check return value of regcache_sync()" to the asoc tree
Date 2016-06-02 12:20 +0200
Message-ID <rFxTj-4Ge-3@gated-at.bofh.it> (permalink)
References <rF0Xn-s6-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The patch

   ASoC: cs53l30: Check return value of regcache_sync()

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 87a4bb11355f8b59c0d865a96044b5853f6c222e Mon Sep 17 00:00:00 2001
From: Nicolin Chen <nicoleotsuka@gmail.com>
Date: Tue, 31 May 2016 16:06:39 -0700
Subject: [PATCH] ASoC: cs53l30: Check return value of regcache_sync()

Regcache_sync() might fail. So this patch adds a return value Check for it.

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/cs53l30.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index 9aff449e57af..ac90dd79857e 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -1055,7 +1055,11 @@ static int cs53l30_runtime_resume(struct device *dev)
 		gpiod_set_value_cansleep(cs53l30->reset_gpio, 1);
 
 	regcache_cache_only(cs53l30->regmap, false);
-	regcache_sync(cs53l30->regmap);
+	ret = regcache_sync(cs53l30->regmap);
+	if (ret) {
+		dev_err(dev, "failed to synchronize regcache: %d\n", ret);
+		return ret;
+	}
 
 	return 0;
 }
-- 
2.8.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] ASoC: cs53l30: Rename the volume controls for preamplifier Nicolin Chen <nicoleotsuka@gmail.com> - 2016-06-01 01:10 +0200
  [PATCH 2/2] ASoC: cs53l30: Check return value of regcache_sync() Nicolin Chen <nicoleotsuka@gmail.com> - 2016-06-01 01:10 +0200
    Re: [PATCH 2/2] ASoC: cs53l30: Check return value of regcache_sync() "Handrigan, Paul" <Paul.Handrigan@cirrus.com> - 2016-06-01 03:30 +0200
    Applied "ASoC: cs53l30: Check return value of regcache_sync()" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-06-02 12:20 +0200
  Re: [PATCH 1/2] ASoC: cs53l30: Rename the volume controls for  preamplifier "Handrigan, Paul" <Paul.Handrigan@cirrus.com> - 2016-06-01 03:30 +0200
  Applied "ASoC: cs53l30: Rename the volume controls for preamplifier" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-06-02 12:20 +0200

csiph-web