Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1411996

Re: [PATCH v2 3/7] iio: adc: ad7793: claim direct mode when writing frequency

From Lars-Peter Clausen <lars@metafoo.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2 3/7] iio: adc: ad7793: claim direct mode when writing frequency
Date 2016-06-02 10:40 +0200
Message-ID <rFwkx-3Ay-3@gated-at.bofh.it> (permalink)
References <rFsqC-1dm-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 06/02/2016 06:28 AM, Alison Schofield wrote:
> Driver was checking for direct mode and trying to lock it, but
> left a gap where mode could change before the desired operation.
> Use iio_device_claim_direct_mode() to guarantee device stays in
> direct mode.
> 
> Refactor function to clarify look-up followed by lock sequence.
> 
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>

Looks good, thanks.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 3/7] iio: adc: ad7793: claim direct mode when writing  frequency Alison Schofield <amsfield22@gmail.com> - 2016-06-02 06:30 +0200
  Re: [PATCH v2 3/7] iio: adc: ad7793: claim direct mode when writing  frequency Lars-Peter Clausen <lars@metafoo.de> - 2016-06-02 10:40 +0200
    Re: [PATCH v2 3/7] iio: adc: ad7793: claim direct mode when writing  frequency Jonathan Cameron <jic23@kernel.org> - 2016-06-03 14:10 +0200

csiph-web