Groups > linux.kernel > #1411901

Re: [PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump
Date	2016-06-02 08:40 +0200
Message-ID	<rFusq-2oO-45@gated-at.bofh.it> (permalink)
References	<rFhlz-2kH-111@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Kangjie Lu <kangjielu@gmail.com>
Date: Wed,  1 Jun 2016 12:34:55 -0400

> diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
> index f795b1d..115aafa 100644
> --- a/net/tipc/netlink_compat.c
> +++ b/net/tipc/netlink_compat.c
> @@ -604,6 +604,7 @@ static int tipc_nl_compat_link_dump(struct tipc_nl_compat_msg *msg,
>  
>  	link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]);
>  	link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP]));
> +	memset((void *)link_info.str, 0, TIPC_MAX_LINK_NAME);
>  	strcpy(link_info.str, nla_data(link[TIPC_NLA_LINK_NAME]));
>  

Please instead use "nla_strlcpy()".

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump Kangjie Lu <kangjielu@gmail.com> - 2016-06-01 18:40 +0200
  Re: [PATCH] tipc: fix an infoleak in tipc_nl_compat_link_dump David Miller <davem@davemloft.net> - 2016-06-02 08:40 +0200

csiph-web