Groups > linux.kernel > #1411921

Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Gerd Hoffmann <kraxel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm
Date	Thu, 02 Jun 2016 09:00:02 +0200
Message-ID	<rFuLM-2xr-27@gated-at.bofh.it> (permalink)
References	<rFmbv-5DL-15@gated-at.bofh.it> <rFmuR-60k-7@gated-at.bofh.it> <rFmXU-6a2-5@gated-at.bofh.it> <rFmXU-6a2-7@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
Content-Type	text/plain; charset="UTF-8"
Content-Transfer-Encoding	8BIT
MIME-Version	1.0
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.23
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 02 Jun 2016 06:56:09 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	Eric Anholt <eric@anholt.net>, linux-rpi-kernel@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Russell King <linux@armlinux.org.uk>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>, open list <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 02 Jun 2016 08:56:05 +0200
X-Original-Message-ID	<1464850565.24775.40.camel@redhat.com>
X-Original-References	<1464817421-8519-1-git-send-email-kraxel@redhat.com> <7065434.SNfT8zjcK3@wuerfel> <87zir4leyc.fsf@eliezer.anholt.net> <5616246.RRQ2rLjLud@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1411921

Show key headers only | View raw

On Do, 2016-06-02 at 00:39 +0200, Arnd Bergmann wrote:
> On Wednesday, June 1, 2016 3:30:35 PM CEST Eric Anholt wrote:
> > Arnd Bergmann <arnd@arndb.de> writes:
> > 
> > > On Wednesday, June 1, 2016 11:43:18 PM CEST Gerd Hoffmann wrote:
> > >> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> > >> new file mode 100644
> > >> index 0000000..36178a6
> > >> --- /dev/null
> > >> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> > >> @@ -0,0 +1 @@
> > >> +#include "../../../arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts"
> > >> -- 
> > >> 1.8.3.1
> > >> 
> > >
> > > What does this gain you?
> > 
> > Many Raspberry Pi users use a small set of SD cards that they swap
> > between various versions of the hardware.  It would be good to have
> > their 32-bit OS images work on the Pi3 as well.
> 
> Sure, but you already have the dts file in the other directory,
> and the dtb is the same.
> 
> According to the comment in the other patch, the idea was to have
> the file in the arm64 directory because it's a 64-bit platform,
> but now you have it here as well.

Well, it just includes the arm64 version as-is, so we don't have
duplication.  I'm open to suggestions to how handle this better.  

Symbolic link?

Reference to ../../../arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
directly in the Makefile?

I've seen arch/arm/boot/dts/Makefile uses globs on *.dts, so I suspect
the later wouldn't be that straight forward.

cheers,
  Gerd

Thread

[PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Gerd Hoffmann <kraxel@redhat.com> - 2016-06-02 00:00 +0200
  Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Arnd Bergmann <arnd@arndb.de> - 2016-06-02 00:10 +0200
    Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Eric Anholt <eric@anholt.net> - 2016-06-02 00:40 +0200
      Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Arnd Bergmann <arnd@arndb.de> - 2016-06-02 00:40 +0200
        Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Gerd Hoffmann <kraxel@redhat.com> - 2016-06-02 09:00 +0200
          Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Arnd Bergmann <arnd@arndb.de> - 2016-06-02 09:30 +0200
            Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Gerd Hoffmann <kraxel@redhat.com> - 2016-06-02 11:20 +0200
              Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Arnd Bergmann <arnd@arndb.de> - 2016-06-02 12:00 +0200
                Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Gerd Hoffmann <kraxel@redhat.com> - 2016-06-02 17:20 +0200
                Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Arnd Bergmann <arnd@arndb.de> - 2016-06-02 17:30 +0200

csiph-web