Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411913

Re: [PATCH 01/32] arm64: Add platform selection for BCM2835.

From Gerd Hoffmann <kraxel@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 01/32] arm64: Add platform selection for BCM2835.
Date 2016-06-02 08:50 +0200
Message-ID <rFuC6-2sz-33@gated-at.bofh.it> (permalink)
References <rFmbv-5DL-15@gated-at.bofh.it> <rFmlc-5Hs-21@gated-at.bofh.it> <rFmld-5Hs-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> >  config ARCH_BCM2835
> >  	bool "Broadcom BCM2835 family"
> > -	depends on ARCH_MULTI_V6 || ARCH_MULTI_V7
> > +	depends on ARCH_MULTI_V6 || ARCH_MULTI_V7 || ARM64
> 
> Humm, what does that achieve?

Nothing ;)

Slipped through unnoticed, I'll drop it.

> > +config ARCH_BCM
> > +	bool "Broadcom SoC Support"
> > +	help
> > +	  This enables support for Broadcom ARM based SoC chips
> 
> menuconfig maybe?

There isn't any in arch/arm64/Kconfig.platforms right now, so I didn't
feel like introducing one.  Also the dependency should have pretty much
the same effect ...

> > +config ARCH_BCM2835
> > +	bool "Broadcom BCM2835 family"
> > +	depends on ARCH_BCM
> > +	select ARCH_REQUIRE_GPIOLIB
> > +	select CLKSRC_OF
> > +	select PINCTRL
> > +	select PINCTRL_BCM2835
> > +	select ARM_AMBA
> > +	select ARM_TIMER_SP804
> > +	select HAVE_ARM_ARCH_TIMER
> > +	help
> > +	  This enables support for the Broadcom BCM2837 SoC.
> > +	  This SoC is used in the Raspberry Pi 3 device.
> > +
> >  config ARCH_BCM_IPROC
> >  	bool "Broadcom iProc SoC Family"
> > +	depends on ARCH_BCM
> 
> Does not seem necessary nor adding anything here.

Added for consistency.  When we add ARCH_BCM all ARCH_BCM_* should
depend on it ...

We could also do it the other way around: make ARCH_BCM a hidden bool
and have ARCH_BCM_* select it.

cheers,
  Gerd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 01/32] arm64: Add platform selection for BCM2835. Florian Fainelli <f.fainelli@gmail.com> - 2016-06-02 00:00 +0200
  Re: [PATCH 01/32] arm64: Add platform selection for BCM2835. Gerd Hoffmann <kraxel@redhat.com> - 2016-06-02 08:50 +0200
    Re: [PATCH 01/32] arm64: Add platform selection for BCM2835. Ray Jui <ray.jui@broadcom.com> - 2016-06-02 18:30 +0200
      Re: [PATCH 01/32] arm64: Add platform selection for BCM2835. Scott Branden <scott.branden@broadcom.com> - 2016-06-02 18:50 +0200
        Re: [PATCH 01/32] arm64: Add platform selection for BCM2835. Gerd Hoffmann <kraxel@redhat.com> - 2016-06-02 19:20 +0200
          Re: [PATCH 01/32] arm64: Add platform selection for BCM2835. Scott Branden <scott.branden@broadcom.com> - 2016-06-02 19:30 +0200
            Re: [PATCH 01/32] arm64: Add platform selection for BCM2835. Florian Fainelli <f.fainelli@gmail.com> - 2016-06-02 19:40 +0200
    Re: [PATCH 01/32] arm64: Add platform selection for BCM2835. Catalin Marinas <catalin.marinas@arm.com> - 2016-06-02 19:40 +0200

csiph-web