Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1411858

[PATCH 1/3] of_numa: Use of_get_next_parent to simplify code

From Kefeng Wang <wangkefeng.wang@huawei.com>
Newsgroups linux.kernel
Subject [PATCH 1/3] of_numa: Use of_get_next_parent to simplify code
Date 2016-06-02 08:10 +0200
Message-ID <rFtZn-2eE-7@gated-at.bofh.it> (permalink)
References <rFqyt-8tG-3@gated-at.bofh.it> <rFtZn-2eE-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Use of_get_next_parent() instead of open-code.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/of/of_numa.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index 3157130..ed7bd22 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -153,8 +153,6 @@ int of_node_to_nid(struct device_node *device)
 	np = of_node_get(device);
 
 	while (np) {
-		struct device_node *parent;
-
 		r = of_property_read_u32(np, "numa-node-id", &nid);
 		/*
 		 * -EINVAL indicates the property was not found, and
@@ -165,9 +163,7 @@ int of_node_to_nid(struct device_node *device)
 		if (r != -EINVAL)
 			break;
 
-		parent = of_get_parent(np);
-		of_node_put(np);
-		np = parent;
+		np = of_get_next_parent(np);
 	}
 	if (np && r)
 		pr_warn("NUMA: Invalid \"numa-node-id\" property in node %s\n",
-- 
1.7.12.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 0/5] fix some type infos and bugs for arm64/of numa Zhen Lei <thunder.leizhen@huawei.com> - 2016-06-02 04:40 +0200
  [PATCH 0/3] of: numa: cleanup Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-02 08:10 +0200
    [PATCH 1/3] of_numa: Use of_get_next_parent to simplify code Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-02 08:10 +0200
    [PATCH 3/3] arm64: numa: Use pr_fmt() Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-02 08:10 +0200
    [PATCH 2/3] of_numa: Use pr_fmt() Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-06-02 08:10 +0200

csiph-web