Re: [PATCH v3 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork()

From	Yuyang Du <yuyang.du@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork()
Date	2016-06-02 05:00 +0200
Message-ID	<rFr1v-bC-7@gated-at.bofh.it> (permalink)
References	<rFcFb-7Qb-11@gated-at.bofh.it> <rFcFc-7Qb-39@gated-at.bofh.it> <rFdrA-8lQ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 01, 2016 at 02:24:29PM +0200, Vincent Guittot wrote:
> On 1 June 2016 at 05:41, Yuyang Du <yuyang.du@intel.com> wrote:
> > Move new task initialization to sched_fork(). For initial non-fair class
> > task, the first switched_to_fair() will do the attach correctly.
> 
> Not sure to catch the explanation. you have only moved and renamed
> init_entity_runnable_average but you speak about initial non-fair
> class

The non-fair class task mentioning is that I stopped a bit to figure
out whether only call sched_fork_fair(), but obviously sched classes
can change, so we should call sched_fork.

And this patch is ammeneable to the previous fix to switched_to().

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] sched/fair: Fix attach and detach sched avgs for task group change or sched class change Yuyang Du <yuyang.du@intel.com> - 2016-06-01 13:40 +0200
  [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Yuyang Du <yuyang.du@intel.com> - 2016-06-01 13:40 +0200
    Re: [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-01 14:30 +0200
      Re: [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Yuyang Du <yuyang.du@intel.com> - 2016-06-02 05:20 +0200
        Re: [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-02 09:40 +0200
          Re: [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-02 09:50 +0200
            Re: [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Yuyang Du <yuyang.du@intel.com> - 2016-06-02 09:50 +0200
          Re: [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Yuyang Du <yuyang.du@intel.com> - 2016-06-02 09:50 +0200
  [PATCH v3 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork() Yuyang Du <yuyang.du@intel.com> - 2016-06-01 13:40 +0200
    Re: [PATCH v3 4/5] sched/fair: Move load and util avgs from  wake_up_new_task() to sched_fork() Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-01 14:30 +0200
      Re: [PATCH v3 4/5] sched/fair: Move load and util avgs from  wake_up_new_task() to sched_fork() Yuyang Du <yuyang.du@intel.com> - 2016-06-02 05:00 +0200

csiph-web