Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc"

From	Scott Wood <oss@buserror.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc"
Date	2016-06-02 03:30 +0200
Message-ID	<rFpCp-7NR-7@gated-at.bofh.it> (permalink)
References	<rvmZg-4Nh-97@gated-at.bofh.it> <rCUMp-1rT-5@gated-at.bofh.it> <rCYdk-3zo-27@gated-at.bofh.it> <rEvgR-4GH-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-05-30 at 15:18 +0200, Arnd Bergmann wrote:
> All users of this driver are PowerPC specific and the header file
> has no business in the global include/linux/ hierarchy, so move
> it back before anyone starts using it on ARM.
> 
> This reverts commit 948486544713492f00ac8a9572909101ea892cb0.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This part of the series is not required for the eSDHC quirk,
> but it restores the asm/fsl_guts.h header so it doesn't accidentally
> get abused for this in the future. I found two drivers outside of
> arch/powerpc that already accessed the registers directly, but the
> functions look fairly contained, and can be easily hidden in an
> #ifdef CONFIG_PPC

NACK

Besides adding ifdef pollution for no good reason, this register block is used
on some ARM chips as well.  Why is it a problem if "anyone starts using it on
ARM"?

BTW, of all the mailing lists you included on this CC, you seem to have left
off the PPC list (I've added it).

-Scott

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of  arch/powerpc" Scott Wood <oss@buserror.net> - 2016-06-02 03:30 +0200
  Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc" Arnd Bergmann <arnd@arndb.de> - 2016-06-02 13:50 +0200
    Re: [PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of  arch/powerpc" Scott Wood <oss@buserror.net> - 2016-06-11 04:20 +0200

csiph-web