Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1411648
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs |
| Date | 2016-06-02 01:20 +0200 |
| Message-ID | <rFnAB-6CD-7@gated-at.bofh.it> (permalink) |
| References | <rES3L-3kr-5@gated-at.bofh.it> <rES3M-3kr-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Pramod Kumar <pramod.kumar@broadcom.com>
Date: Tue, 31 May 2016 19:06:39 +0530
> +static int iproc_mdio_wait_for_idle(void __iomem *base, bool result)
> +{
> + u32 val;
> + unsigned int timeout = 1000; /* loop for 1s */
Please order your local variable declarations from longest to shortest line.
> +static int start_miim_ops(void __iomem *base,
> + u16 phyid, u32 reg, u16 val, u32 op)
> +{
> + int ret;
> + u32 param;
Likewise.
> +static int iproc_mdiomux_read(struct mii_bus *bus, int phyid, int reg)
> +{
> + int ret;
> + struct iproc_mdiomux_desc *md = bus->priv;
Likewise.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/7] Add MDIO bus multiplexer support for iProc SoCs Pramod Kumar <pramod.kumar@broadcom.com> - 2016-05-31 15:40 +0200
[PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs Pramod Kumar <pramod.kumar@broadcom.com> - 2016-05-31 15:40 +0200
Re: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs David Miller <davem@davemloft.net> - 2016-06-02 01:20 +0200
RE: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-03 15:50 +0200
[PATCH v2 2/7] DT: phy.txt: Add mdio-integrated-mux property Pramod Kumar <pramod.kumar@broadcom.com> - 2016-05-31 15:40 +0200
Re: [PATCH v2 2/7] DT: phy.txt: Add mdio-integrated-mux property Rob Herring <robh@kernel.org> - 2016-06-03 01:30 +0200
Re: [PATCH v2 2/7] DT: phy.txt: Add mdio-integrated-mux property Andrew Lunn <andrew@lunn.ch> - 2016-06-03 02:50 +0200
csiph-web