Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1411604

Re: [PATCH] relay: fix potential memory leak

From Andrew Morton <akpm@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] relay: fix potential memory leak
Date 2016-06-02 00:00 +0200
Message-ID <rFmld-5Hs-49@gated-at.bofh.it> (permalink)
References <rFc2u-7m8-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed,  1 Jun 2016 18:45:27 +0800 Zhouyi Zhou <yizhouzhou@ict.ac.cn> wrote:

> when relay_open_buf fails in relay_open, program will goto free_bufs,
> but chan is nowhere freed.

OK.

> In addition, give warning to users who forget to provide create file
> hook. 	 

Why?  What's the value in this?

If the user didn't provide ->create_buf_file then setup_callbacks()
will provide them with create_buf_file_default_callback() - what's
wrong with that?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] relay: fix potential memory leak Zhouyi Zhou <yizhouzhou@ict.ac.cn> - 2016-06-01 13:00 +0200
  Re: [PATCH] relay: fix potential memory leak Andrew Morton <akpm@linux-foundation.org> - 2016-06-02 00:00 +0200
    Re: Re: [PATCH] relay: fix potential memory leak "Zhouyi Zhou" <yizhouzhou@ict.ac.cn> - 2016-06-02 03:30 +0200
      Re: [PATCH] relay: fix potential memory leak Andrew Morton <akpm@linux-foundation.org> - 2016-06-02 04:20 +0200

csiph-web