Re: [PATCH v6 0/8] block: prepare for multipage bvecs

Path	csiph.com!news.mixmin.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Mike Snitzer <snitzer@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 0/8] block: prepare for multipage bvecs
Date	Wed, 01 Jun 2016 16:00:01 +0200
Message-ID	<rFeQF-Fc-1@gated-at.bofh.it> (permalink)
References	<rEvAe-4Ni-11@gated-at.bofh.it> <rEUff-4Bu-9@gated-at.bofh.it> <rFdBg-8pl-17@gated-at.bofh.it> <rFeH0-BQ-23@gated-at.bofh.it>
X-Original-To	Christoph Hellwig <hch@infradead.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.24
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 01 Jun 2016 13:51:52 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	Ming Lei <ming.lei@canonical.com>, Jens Axboe <axboe@fb.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-block@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>, "open list:DRBD DRIVER" <drbd-dev@lists.linbit.com>, Jan Kara <jack@suse.cz>, Joe Thornber <ejt@redhat.com>, Keith Busch <keith.busch@intel.com>, Kent Overstreet <kent.overstreet@gmail.com>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Michal Hocko <mhocko@suse.com>, NeilBrown <neilb@suse.com>, Sagi Grimberg <sagig@mellanox.com>, Shaohua Li <shli@fb.com>, Steven Whitehouse <swhiteho@redhat.com>, Tejun Heo <tj@kernel.org>, "open list:XFS FILESYSTEM" <xfs@oss.sgi.com>
X-Original-Date	Wed, 1 Jun 2016 09:51:51 -0400
X-Original-Message-ID	<20160601135150.GA30759@redhat.com>
X-Original-References	<1464615294-9946-1-git-send-email-ming.lei@canonical.com> <20160531155348.GA24840@redhat.com> <CACVXFVM9FqZFkMat_4ysJ8_vFd1FFnf6Bd9sHDDoCK=v93wViQ@mail.gmail.com> <20160601134427.GA15888@infradead.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1411241

Show key headers only | View raw

On Wed, Jun 01 2016 at  9:44am -0400,
Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote:
> > > be dm-crypt.c.  Maybe you've identified some indirect use of
> > > BIO_MAX_SIZE?
> > 
> > I mean the recently introduced BIO_MAX_SIZE in -next tree:
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/md/dm-crypt.c?id=4ed89c97b0706477b822ea2182827640c0cec486
> 
> The crazy bcache bios striking back once again.  I really think it's
> harmful having a _MAX value and then having a minor driver
> reinterpreting it and sending larger ones.  Until we can lift the
> maximum limit in general nad have common code exercise it we really need
> to stop bcache from sending these instead of littering the tree with
> workarounds.

So should I not push this type of fix to Linus now?  I was going to send
the above commit and this one to him this week:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.7&id=57b3001b240629ecc5266d28c845e23ca5f11719

Instead, should bcache be made to not do what it is doing?

Thread

Re: [PATCH v6 0/8] block: prepare for multipage bvecs Mike Snitzer <snitzer@redhat.com> - 2016-05-31 18:00 +0200
  Re: [PATCH v6 0/8] block: prepare for multipage bvecs Ming Lei <ming.lei@canonical.com> - 2016-06-01 14:40 +0200
    Re: [PATCH v6 0/8] block: prepare for multipage bvecs Christoph Hellwig <hch@infradead.org> - 2016-06-01 15:50 +0200
      Re: [PATCH v6 0/8] block: prepare for multipage bvecs Mike Snitzer <snitzer@redhat.com> - 2016-06-01 16:00 +0200
        Re: [PATCH v6 0/8] block: prepare for multipage bvecs Christoph Hellwig <hch@infradead.org> - 2016-06-01 16:10 +0200
        Re: [PATCH v6 0/8] block: prepare for multipage bvecs Ming Lei <ming.lei@canonical.com> - 2016-06-02 04:20 +0200

csiph-web