RE: [PATCH v3] Drivers: hv: vmbus: fix the race when querying & updating the percpu list

From	Dexuan Cui <decui@microsoft.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v3] Drivers: hv: vmbus: fix the race when querying & updating the percpu list
Date	2016-06-01 12:10 +0200
Message-ID	<rFbg6-74G-37@gated-at.bofh.it> (permalink)
References	<rBtbz-4zT-1@gated-at.bofh.it> <rEUIh-50B-1@gated-at.bofh.it> <rF88y-4XQ-53@gated-at.bofh.it> <rFaan-6aY-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> >> [    5.472143] BUG: unable to handle kernel paging request at
> >> 000000079fff5288
> >> [    5.477107] IP: [<ffffffffa0004b91>] vmbus_onoffer+0x311/0x570
> >> [hv_vmbus]
> >> ...
> >>   Vitaly
> >
> > I can't reproduce the panic somehow, but I did find a bug in
> vmbus_process_offer():
> >
> > "hv_event_tasklet_disable(channel) and
> hv_event_tasklet_enable(channel)"
> > are buggy: the 'channel' parameter should be 'newchannel'.
> >
> > This was a copy-and-paste bug... Sorry!
> > Can you fix this and see if the panic will disappear in your side?
> 
> This fixes the issue I'm seeing, thanks!
> 
>   Vitaly

Many thanks, Vitaly!

I'll post v4 shortly.

Thanks,
-- Dexuan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] Drivers: hv: vmbus: fix the race when querying & updating the percpu list Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-05-31 18:30 +0200
  RE: [PATCH v3] Drivers: hv: vmbus: fix the race when querying &  updating the percpu list Dexuan Cui <decui@microsoft.com> - 2016-06-01 08:50 +0200
    Re: [PATCH v3] Drivers: hv: vmbus: fix the race when querying & updating the percpu list Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-06-01 11:00 +0200
      RE: [PATCH v3] Drivers: hv: vmbus: fix the race when querying &  updating the percpu list Dexuan Cui <decui@microsoft.com> - 2016-06-01 12:10 +0200

csiph-web