Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1411041

Re: [PATCH v1] mm: thp: check pmd_trans_unstable() after split_huge_pmd()

Path csiph.com!goblin3!goblin1!goblin.stu.neva.ru!news2.arglkargh.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From "Kirill A. Shutemov" <kirill@shutemov.name>
Newsgroups linux.kernel
Subject Re: [PATCH v1] mm: thp: check pmd_trans_unstable() after split_huge_pmd()
Date Wed, 01 Jun 2016 11:50:02 +0200
Message-ID <rFaWK-6IP-21@gated-at.bofh.it> (permalink)
References <rF2mu-1c3-9@gated-at.bofh.it>
X-Original-To Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2weobvzVd07/6tbRJAiDK4UNZavuT0/d0hIAq5AwBBM=; b=2Ei0+WC6KWdripT9zwcIFxY3CzMzAz8aqUCq/o+sCwSVAPIeUjw61Pe6EhTdFdRLvT HVfw+XRCOCGFVKNUKXymuR1Ml9V00Cwm1fzTRonIvsiM+qintzXM+CHW3hCgHR9VdRwL MUIBi/2bwLt6GANMP5D18mYZmV9fQj5jwxq9x0MWGMfGX6C7Z6ZSZ83ZHqMh17HhMAcR wmn9//sjn7SqFyn+1wZ1GfCmrOVvTm0ODJHBFrqYwM73g6TN4TwAWMACqKh2mO22dc3z 6d1hEfTitS65hKXm1FTp7Zj5kHwIr0b63oSL2JmHt5vRFl8yeF8KHWWkcGIwt0f26TJc v4yw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2weobvzVd07/6tbRJAiDK4UNZavuT0/d0hIAq5AwBBM=; b=H+MSgnPttEB4JIknJ+FIuF/G57qjRH45QjpBSp75dAwJne87eWYov/AOedi90XuEyJ 2MCiGD4cFsJxDh+X8L+Q4KF69j8kok4GR9w5vamtVUDYVq6kY8QgI//0joZP0MEgMCO8 M/M0mzemBlYov+XDdAv6ZOImieko1FlQmEepXIK6gA8AOu6humUOq3Z0xgT5zmZapor+ ze9rlfJ1zV/mah2bUAlMDFQ5RfRTbePyGmE/KFZgaM2BTeRScn4F9inX5YikcvN6db4D OV5dT55BfV935qFql9t9iZFGN+h/1TMdQoMzoAL+jNP+Z+p8pDb6tVb1rHrlIeQ+9K6N buzg==
X-Gm-Message-State ALyK8tIcBFjqHoRSvNN1UZ3FyG8W/qpwXPEfe2fNuSUxtu6Jp4cCD9RwboZBLcZKtGL4hg==
X-Received by 10.25.127.6 with SMTP id a6mr1204862lfd.111.1464774000159; Wed, 01 Jun 2016 02:40:00 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.23.1 (2014-03-12)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 12
Organization linux.* mail to news gateway
X-Original-Cc Andrew Morton <akpm@linux-foundation.org>, Hugh Dickins <hughd@google.com>, Mel Gorman <mgorman@techsingularity.net>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Naoya Horiguchi <nao.horiguchi@gmail.com>
X-Original-Date Wed, 1 Jun 2016 12:39:57 +0300
X-Original-Message-ID <20160601093957.GA8493@node.shutemov.name>
X-Original-References <1464741400-12143-1-git-send-email-n-horiguchi@ah.jp.nec.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1411041

Show key headers only | View raw


On Wed, Jun 01, 2016 at 09:36:40AM +0900, Naoya Horiguchi wrote:
> split_huge_pmd() doesn't guarantee that the pmd is normal pmd pointing to
> pte entries, which can be checked with pmd_trans_unstable().

Could you be more specific on when we don't have normal ptes after
split_huge_pmd? Race with other thread? DAX?

I guess we can modify split_huge_pmd() to return if the pmd was split or
not.

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v1] mm: thp: check pmd_trans_unstable() after split_huge_pmd() Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-06-01 02:40 +0200
  Re: [PATCH v1] mm: thp: check pmd_trans_unstable() after  split_huge_pmd() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-06-01 11:50 +0200
    Re: [PATCH v1] mm: thp: check pmd_trans_unstable() after  split_huge_pmd() Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2016-06-02 02:40 +0200

csiph-web