Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1413233

Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

Show all headers | View raw

On 06/03/2016 03:06 AM, Jonathan Cameron wrote:
> On 01/06/16 13:34, Laxman Dewangan wrote:
>> The INA3221 is a three-channel, high-side current and bus voltage monitor
>> with an I2C interface from Texas Instruments. The INA3221 monitors both
>> shunt voltage drops and bus supply voltages in addition to having
>> programmable conversion times and averaging modes for these signals.
>> The INA3221 offers both critical and warning alerts to detect multiple
>> programmable out-of-range conditions for each channel.
>>
>> Add support for INA3221 SW driver via IIO ADC interface. The device is
>> register as iio-device and provides interface for voltage/current and power
>> monitor. Also provide interface for setting oneshot/continuous mode and
>> critical/warning threshold for the shunt voltage drop.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Hi Laxman,
>
> As ever with any driver lying on the border of IIO and hwmon, please include
> a short justification of why you need an IIO driver and also cc the
> hwmon list + maintainers. (cc'd on this reply).
>
> I simply won't take a driver where the hwmon maintainers aren't happy.
> As it stands I'm not seeing obvious reasons in the code for why this
> should be an IIO device.
>

Me not either.

I have a hwmon driver for the same chip pending from Andrew Davis (TI)
which I am just about to accept. We had directed Andrew back in April
to write a hwmon driver for the chip, which he did.

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] iio: adc: ina3221: Add DT binding details Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-01 14:50 +0200
  [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-01 14:50 +0200
    Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for  TI INA3221 Jonathan Cameron <jic23@kernel.org> - 2016-06-03 12:10 +0200
      Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver  for TI INA3221 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-03 13:40 +0200
        Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for  TI INA3221 Jonathan Cameron <jic23@kernel.org> - 2016-06-03 14:10 +0200
          Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver  for TI INA3221 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-03 14:30 +0200
      Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver  for TI INA3221 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-03 13:50 +0200
        Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for  TI INA3221 Jonathan Cameron <jic23@kernel.org> - 2016-06-03 14:10 +0200
          Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver  for TI INA3221 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-03 14:20 +0200
      Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for  TI INA3221 Guenter Roeck <linux@roeck-us.net> - 2016-06-03 15:30 +0200
        Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver  for TI INA3221 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-03 16:30 +0200
          Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for  TI INA3221 "Andrew F. Davis" <afd@ti.com> - 2016-06-03 17:20 +0200
            Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver  for TI INA3221 Guenter Roeck <linux@roeck-us.net> - 2016-06-08 00:40 +0200
              Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for  TI INA3221 "Andrew F. Davis" <afd@ti.com> - 2016-06-08 17:10 +0200
                Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver  for TI INA3221 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-08 18:00 +0200
  [PATCH 3/3] iio: adc: ina3221: Add sysfs details for TI INA3221 Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-01 14:50 +0200
    Re: [PATCH 3/3] iio: adc: ina3221: Add sysfs details for TI INA3221 Jonathan Cameron <jic23@kernel.org> - 2016-06-03 12:30 +0200
  Re: [PATCH 1/3] iio: adc: ina3221: Add DT binding details Rob Herring <robh@kernel.org> - 2016-06-03 04:10 +0200
    Re: [PATCH 1/3] iio: adc: ina3221: Add DT binding details Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-03 11:20 +0200
    Re: [PATCH 1/3] iio: adc: ina3221: Add DT binding details Jonathan Cameron <jic23@kernel.org> - 2016-06-03 12:20 +0200
      Re: [PATCH 1/3] iio: adc: ina3221: Add DT binding details Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-03 14:10 +0200
        Re: [PATCH 1/3] iio: adc: ina3221: Add DT binding details Jonathan Cameron <jic23@kernel.org> - 2016-06-03 14:20 +0200
          Re: [PATCH 1/3] iio: adc: ina3221: Add DT binding details Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-03 14:40 +0200

csiph-web