Re: [PATCH v4 15/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node

From	Peter Griffin <peter.griffin@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 15/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node
Date	2016-06-03 15:10 +0200
Message-ID	<rFX1p-3yL-49@gated-at.bofh.it> (permalink)
References	<rCJxD-32M-5@gated-at.bofh.it> <rCJxD-32M-3@gated-at.bofh.it> <rENQt-Jk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnaud,

Thanks for reviewing.

On Tue, 31 May 2016, Arnaud Pouliquen wrote:
> 
> 
> On 05/25/2016 06:06 PM, Peter Griffin wrote:
> > This patch adds the dt node for the internal audio
> > codec IP.
> > 
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> >  arch/arm/boot/dts/stih407-family.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> > index b423836..60f95b6 100644
> > --- a/arch/arm/boot/dts/stih407-family.dtsi
> > +++ b/arch/arm/boot/dts/stih407-family.dtsi
> > @@ -746,5 +746,14 @@
> >  				<&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>,
> >  				<&clk_s_c0_flexgen CLK_EXT2F_A9>;
> >  		};
> > +
> > +		sti_sasg_codec: sti-sasg-codec {
> > +			compatible = "st,stih407-sas-codec";
> > +			#sound-dai-cells = <1>;
> > +			status = "okay";
> Should be set to disable in family and enabled it depending on boards
> (stihxxx-b2120.dtsi)

Will fix in v5

> > +			st,syscfg = <&syscfg_core>;
> > +			pinctrl-names = "default";
> > +			pinctrl-0 = <&pinctrl_spdif_out >;
> Declare pinctrl use in stihxxx-b2120.dtsi, should be set only if SPDIF used.

Will fix in v5

regards,

Peter.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 15/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt  node Arnaud Pouliquen <arnaud.pouliquen@st.com> - 2016-05-31 11:10 +0200
  Re: [PATCH v4 15/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt  node Peter Griffin <peter.griffin@linaro.org> - 2016-06-03 15:10 +0200

csiph-web