Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1413197

Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property

Show all headers | View raw

On 06/03/2016 04:02 AM, Rob Herring wrote:
> On Wed, Jun 01, 2016 at 10:02:15AM +0200, Krzysztof Kozlowski wrote:
>> Some devices need real hard-reset by cutting the power.  During power
>> sequence turn off and on the regulator, if it is provided.
>>
>> Additionally add support for instantiating the pwrseq-simple device on a
>> generic property 'power-sequence'.  The device will attach itself to the
>> node containing the property and parse the node's properties like
>> reset-gpios, ext-supply etc.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>>  .../bindings/power/pwrseq/pwrseq-simple.txt        | 29 +++++++-
>>  drivers/power/pwrseq/pwrseq_simple.c               | 85 +++++++++++++++++++++-
>>  2 files changed, 107 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt b/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt
>> index ce0e76749671..a8c3f13ee83f 100644
>> --- a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt
>> +++ b/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt
>> @@ -1,11 +1,17 @@
>> -* The simple MMC power sequence provider
>> +* The simple power sequence provider
>>  
>> -The purpose of the simple MMC power sequence provider is to supports a set of
>> +The purpose of the simple power sequence provider is to supports a set of
>>  common properties between various SOC designs. It thus enables us to use the
>>  same provider for several SOC designs.
>>  
>> -Required properties:
>> -- compatible : contains "mmc-pwrseq-simple".
>> +The driver supports two types of bindings:
>> +1. Separate node
>> +   Required properties:
>> +   - compatible : contains "mmc-pwrseq-simple".
> 
> Please note that this is not recommended for new users.

Sure.

> 
>> +
>> +2. Property for any node
>> +   Required properties:
>> +   - power-sequence
>>  
>>  Optional properties:
>>  - reset-gpios : contains a list of GPIO specifiers. The reset GPIOs are asserted
>> @@ -16,6 +22,7 @@ Optional properties:
>>    See ../clocks/clock-bindings.txt for details.
>>  - clock-names : Must include the following entry:
>>    "ext_clock" (External clock provided to the card).
>> +- ext-supply : External regulator supply
> 
> What happens when there are 2 supplies?
> 
> I'd prefer the name not be genericish and use the real supply names. 
> Then the power seq code should just turn on all supplies it finds. If 
> the order or timing to turn on matters, then sorry, no generic sequence.

Understood. I'll change the code to use any supply.

As for the genericness of this approach, Sylwester Nawrocki pointed an
old thread:
[PATCH v6 0/4] Runtime Interpreted Power Sequences
https://lkml.org/lkml/2012/9/12/127

How do you like that approach?

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix  USB/LAN when TFTP booting) Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-01 10:10 +0200
  [PATCH v3 02/12] MAINTAINERS: Retain Ulf Hansson as the same  maintainer of pwrseq Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-01 10:20 +0200
  [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and  generic property Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-01 10:20 +0200
    Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for  regulator and generic property Rob Herring <robh@kernel.org> - 2016-06-03 04:10 +0200
      Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator  and generic property Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-03 14:40 +0200
        Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for  regulator and generic property Peter Chen <hzpeterchen@gmail.com> - 2016-06-06 05:30 +0200
      Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator  and generic property Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-07 11:30 +0200
        Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for  regulator and generic property Rob Herring <robh@kernel.org> - 2016-06-08 21:10 +0200
          Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator  and generic property Chen-Yu Tsai <wens@csie.org> - 2016-06-09 04:40 +0200
            Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator  and generic property Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-09 07:20 +0200
  [PATCH v3 10/12] EXAMPLE CODE: usb: hub: Power sequence the ports on  activation Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-01 10:20 +0200
  [PATCH v3 04/12] power: pwrseq: Remove mmc prefix from mmc_pwrseq Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-01 10:20 +0200
  [PATCH v3 03/12] power: pwrseq: Enable COMPILE_TEST for drivers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-01 10:20 +0200
  Re: [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting) Heiko Stübner <heiko@sntech.de> - 2016-06-06 22:50 +0200
    Re: [PATCH v3 00/12] usb/mmc/power: Generic power sequence (and fix  USB/LAN when TFTP booting) Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-07 08:10 +0200

csiph-web