RE: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support

From	Pramod Kumar <pramod.kumar@broadcom.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support
Date	2016-06-03 13:30 +0200
Message-ID	<rFVsC-2ur-3@gated-at.bofh.it> (permalink)
References	<rES3L-3kr-5@gated-at.bofh.it> <rES3L-3kr-7@gated-at.bofh.it> <rFedY-qG-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@lunn.ch]
> Sent: 01 June 2016 18:42
> To: Pramod Kumar
> Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala;
Catalin
> Marinas; Will Deacon; Kishon Vijay Abraham I; David S. Miller;
> devicetree@vger.kernel.org; Jon Mason; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; bcm-kernel-feedback-list@broadcom.com;
linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support
>
> > +static int ns2_pci_phy_probe(struct mdio_device *mdiodev) {
> > +	struct device *dev = &mdiodev->dev;
> > +	struct phy_provider *provider;
> > +	struct ns2_pci_phy *p;
> > +	struct phy *phy;
> > +
> > +	phy = devm_phy_create(dev, dev->of_node, &ns2_pci_phy_ops);
> > +	if (IS_ERR_OR_NULL(phy)) {
> > +		dev_err(dev, "failed to create Phy\n");
> > +		return PTR_ERR(phy);
> > +	}
>
> https://www.mail-archive.com/linux-omap@vger.kernel.org/msg78030.html
>

I've explored inside this API and see it never returning NULL. I'll
replace IS_ERR_OR_NULL to IS_ERR.
Thanks for pointing this out.

> 	Andrew

Regards,
Pramod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar <pramod.kumar@broadcom.com> - 2016-05-31 15:40 +0200
  Re: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support Andrew Lunn <andrew@lunn.ch> - 2016-06-01 15:20 +0200
    RE: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar <pramod.kumar@broadcom.com> - 2016-06-03 13:30 +0200

csiph-web