Re: [PATCH] i2c_hid: enable i2c-hid devices to suspend/resume asynchronously

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c_hid: enable i2c-hid devices to suspend/resume asynchronously
Date	Fri, 03 Jun 2016 10:00:02 +0200
Message-ID	<rFSbo-od-17@gated-at.bofh.it> (permalink)
References	<rAmc9-2ff-5@gated-at.bofh.it>
X-Original-To	"Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.23
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 03 Jun 2016 07:56:09 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	Jiri Kosina <jikos@kernel.org>, dtor@chromium.org, bleung@chromium.org, Mika Westerberg <mika.westerberg@linux.intel.com>, aduggan@synaptics.com, k.kozlowski@samsung.com, dianders@chromium.org, gabriele.mzt@gmail.com, linux-input@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Fri, 3 Jun 2016 09:56:03 +0200
X-Original-Message-ID	<20160603075603.GE23234@mail.corp.redhat.com>
X-Original-References	<573D2900.6090903@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1412878

Show key headers only | View raw

On May 19 2016 or thereabouts, Fu, Zhonghui wrote:
> i2c-hid devices' suspend/resume are usually time-consuming process.
> For example, the touch controller(i2c-ATML1000:00) on ASUS T100 tablet
> takes about 160ms for suspending and 120ms for resuming. This patch
> enables i2c-hid devices to suspend/resume asynchronously. This will
> take advantage of multicore and speed up system suspend/resume process.
> 
> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> ---

In regard with the discussion:
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

>  drivers/hid/i2c-hid/i2c-hid.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 2e021ba..cc41e1e 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1020,6 +1020,7 @@ static int i2c_hid_probe(struct i2c_client *client,
>  	pm_runtime_get_noresume(&client->dev);
>  	pm_runtime_set_active(&client->dev);
>  	pm_runtime_enable(&client->dev);
> +	device_enable_async_suspend(&client->dev);
>  
>  	ret = i2c_hid_fetch_hid_descriptor(ihid);
>  	if (ret < 0)
> -- 1.7.1
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] i2c_hid: enable i2c-hid devices to suspend/resume  asynchronously Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-06-03 10:00 +0200

csiph-web