Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1412934

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0

Show all headers | View raw

On Fri, Jun 03, 2016 at 09:57:22AM +0200, Geert Uytterhoeven wrote:
> Hi Andrew, Mel,
> 
> On Thu, Jun 2, 2016 at 8:43 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Thu, 2 Jun 2016 13:19:36 +0100 Mel Gorman <mgorman@techsingularity.net> wrote:
> >> > >Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> >> >
> >> > Acked-by: Vlastimil Babka <vbabka@suse.cz>
> >> >
> >>
> >> Thanks.
> >
> > I queued this.  A tested-by:Geert would be nice?
> >
> >
> > From: Mel Gorman <mgorman@techsingularity.net>
> > Subject: mm, page_alloc: recalculate the preferred zoneref if the context can ignore memory policies
> >
> > The optimistic fast path may use cpuset_current_mems_allowed instead of of
> > a NULL nodemask supplied by the caller for cpuset allocations.  The
> > preferred zone is calculated on this basis for statistic purposes and as a
> > starting point in the zonelist iterator.
> >
> > However, if the context can ignore memory policies due to being atomic or
> > being able to ignore watermarks then the starting point in the zonelist
> > iterator is no longer correct.  This patch resets the zonelist iterator in
> > the allocator slowpath if the context can ignore memory policies.  This
> > will alter the zone used for statistics but only after it is known that it
> > makes sense for that context.  Resetting it before entering the slowpath
> > would potentially allow an ALLOC_CPUSET allocation to be accounted for
> > against the wrong zone.  Note that while nodemask is not explicitly set to
> > the original nodemask, it would only have been overwritten if
> > cpuset_enabled() and it was reset before the slowpath was entered.
> >
> > Link: http://lkml.kernel.org/r/20160602103936.GU2527@techsingularity.net
> > Fixes: c33d6c06f60f710 ("mm, page_alloc: avoid looking up the first zone in a zonelist twice")
> 
> My understanding was that this was an an additional patch, not fixing
> the problem in-se?
> 

It doesn't fix the problem you had, it is a follow-on patch that
potentially affects.

> Indeed, after applying this patch (without the other one that added
> "z = ac->preferred_zoneref;" to the reset_fair block of
> get_page_from_freelist()) I still get crashes...
> 

The patch you have is the only one required for the crash. This patch
handles a corner case with atomic allocations that can ignore memory
policies.

> Now testing with both applied...

Thanks.

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm,  page_alloc: avoid looking up the first zone in a zonelist twice) Vlastimil Babka <vbabka@suse.cz> - 2016-05-31 23:50 +0200
  Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm,  page_alloc: avoid looking up the first zone in a zonelist twice) Mel Gorman <mgorman@techsingularity.net> - 2016-06-01 11:20 +0200
    Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Vlastimil Babka <vbabka@suse.cz> - 2016-06-01 12:10 +0200
      Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Mel Gorman <mgorman@techsingularity.net> - 2016-06-02 12:40 +0200
        Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Vlastimil Babka <vbabka@suse.cz> - 2016-06-02 14:10 +0200
          Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Mel Gorman <mgorman@techsingularity.net> - 2016-06-02 14:20 +0200
            Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Andrew Morton <akpm@linux-foundation.org> - 2016-06-02 20:50 +0200
              Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Stephen Rothwell <sfr@canb.auug.org.au> - 2016-06-03 06:00 +0200
              Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-03 10:00 +0200
                Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Mel Gorman <mgorman@techsingularity.net> - 2016-06-03 10:50 +0200
                Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-03 11:10 +0200
                Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Andrew Morton <akpm@linux-foundation.org> - 2016-06-03 18:40 +0200
                Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Mel Gorman <mgorman@techsingularity.net> - 2016-06-03 18:50 +0200
                Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 Andrew Morton <akpm@linux-foundation.org> - 2016-06-03 19:00 +0200

csiph-web