Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1412578
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers |
| Date | 2016-06-02 23:50 +0200 |
| Message-ID | <rFIF4-2WQ-23@gated-at.bofh.it> (permalink) |
| References | <rFowF-7d9-5@gated-at.bofh.it> <rFuLM-2xr-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thursday, June 02, 2016 08:57:15 AM Borislav Petkov wrote: > On Wed, Jun 01, 2016 at 05:11:57PM -0700, Dave Hansen wrote: > > +#define INTEL_FAM6_MODEL_CORE_YONAH 0x0E > > +#define INTEL_FAM6_MODEL_CORE2_MEROM 0x0F > > That "MODEL_" part looks redundant too IMO - you could simply do > > INTEL_FAM6_NEHALEM and > INTEL_FAM6_SKYLAKE_DESKTOP > ... > > and so on and it is still clear what it is. I'm with you on that, but that's rather minor and the changes in this series are generally fine by me, so Dave please feel free to add Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> to all of it. Thanks, Rafael
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/20] x86, intel: Introduce macros for Intel family numbers Dave Hansen <dave@sr71.net> - 2016-06-02 02:20 +0200
[PATCH 20/20] x86, powercap, rapl: add Skylake Server model number Dave Hansen <dave@sr71.net> - 2016-06-02 02:20 +0200
[PATCH 08/20] x86, rapl: reorder cpu detection table Dave Hansen <dave@sr71.net> - 2016-06-02 02:20 +0200
Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers Borislav Petkov <bp@alien8.de> - 2016-06-02 09:00 +0200
Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-02 23:50 +0200
Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers Darren Hart <dvhart@infradead.org> - 2016-06-02 23:50 +0200
csiph-web