[PATCH] usb: usbip: fix null pointer dereference

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] usb: usbip: fix null pointer dereference
Date	Thu, 02 Jun 2016 20:00:01 +0200
Message-ID	<rFF4t-HB-5@gated-at.bofh.it> (permalink)
X-Original-To	Valentina Manea <valentina.manea.m@gmail.com>, Shuah Khan <shuah.kh@samsung.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=x0L2tna9LHNLy/6UYI0OxUNENjF5KDruRHqe0IQcnb4=; b=ZfIFTeQEb0UNXx15zwZOl2QkpIuQ53gL4P2zMLXFrN3iGeKsbUSVio0wMHqDIyfe9G vQ0fOqpRLLdyISvR94lSuAUhaCToQBBhk4mU1Dq6yz8K2B/EEgt+GvRQL6xndr7Gb7oU JLM0YhcRIXVOVszvku0ZRKHp+oSSpCoiZtI4oeqnHBQxPpP1XdNrtLd3en5apf7oACR2 AIE4csAZ6wtIhXDsARft1XpRAucOSW/Q6pip29Ss78DFh113mWKoI4I37Na8H4NrCFyJ 7fM2rkk9Aof9CIPoplbLQCqLUK7R4bLIJBJTgGR0sAdJkIL9n+/CGmaS+G06kua1wvBX P8og==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=x0L2tna9LHNLy/6UYI0OxUNENjF5KDruRHqe0IQcnb4=; b=XEJfSOk0y3N9NiwdEIzx4rsJoxZ0XvgaRSJH9LlNLwVor7zqefS1fvKR8Cn6TBSUWO EiiUZnWvQ1KlPZNU8fymrIRJIvYk+0VqqtobBxSbsdwDGI5/fpbbgrqnRonp492bFtMF 0Qb+78otYK7YglpQ+Ja5kXJ97Lgqj8D9w4k5NZf7a4fdDuGW6NMspTpom3KhCkvbSAzz RnTa6Fmg5QBemIKinzBt6jnMgxJ2Kt2gDwlZPOaroDT3jGK7Wkt7n3L+6neICdLw4T9u l35XQTTsxPD3sVBEInmWTlMMNuCklcZlW8IbZp65kcV5Y2IN/lR5LWVhSY2KxgZ/K/o2 /RZw==
X-Gm-Message-State	ALyK8tJv/Bo8cNT8ssJX9xLbkyDabYot++z2G4tSgviuTub0RSOB9zLtpkWmZtnH1NTQTQ==
X-Received	by 10.98.54.133 with SMTP id d127mr6810165pfa.104.1464889970505; Thu, 02 Jun 2016 10:52:50 -0700 (PDT)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Sudip Mukherjee <sudipm.mukherjee@gmail.com>
X-Original-Date	Thu, 2 Jun 2016 18:52:33 +0530
X-Original-Message-ID	<1464873753-11456-1-git-send-email-sudipm.mukherjee@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1412465

Show key headers only | View raw

We have been dereferencing udc before checking it. Lets use it after it
has been checked.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
 drivers/usb/usbip/vudc_sysfs.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c
index 99397fa..0ba6a06 100644
--- a/drivers/usb/usbip/vudc_sysfs.c
+++ b/drivers/usb/usbip/vudc_sysfs.c
@@ -35,14 +35,17 @@
 int get_gadget_descs(struct vudc *udc)
 {
 	struct vrequest *usb_req;
-	struct vep *ep0 = to_vep(udc->gadget.ep0);
-	struct usb_device_descriptor *ddesc = &udc->dev_desc;
+	struct vep *ep0;
+	struct usb_device_descriptor *ddesc;
 	struct usb_ctrlrequest req;
 	int ret;
 
 	if (!udc || !udc->driver || !udc->pullup)
 		return -EINVAL;
 
+	ep0 = to_vep(udc->gadget.ep0);
+	ddesc = &udc->dev_desc;
+
 	req.bRequestType = USB_DIR_IN | USB_TYPE_STANDARD | USB_RECIP_DEVICE;
 	req.bRequest = USB_REQ_GET_DESCRIPTOR;
 	req.wValue = cpu_to_le16(USB_DT_DEVICE << 8);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: usbip: fix null pointer dereference Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-02 20:00 +0200
  Re: [PATCH] usb: usbip: fix null pointer dereference Krzysztof Opasiak <k.opasiak@samsung.com> - 2016-06-03 10:30 +0200
    Re: [PATCH] usb: usbip: fix null pointer dereference Alan Stern <stern@rowland.harvard.edu> - 2016-06-03 16:30 +0200
    Re: [PATCH] usb: usbip: fix null pointer dereference Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-05 20:00 +0200
      Re: [PATCH] usb: usbip: fix null pointer dereference Krzysztof Opasiak <k.opasiak@samsung.com> - 2016-06-06 10:30 +0200
        Re: [PATCH] usb: usbip: fix null pointer dereference Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-06 10:50 +0200

csiph-web