Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1412413
| From | "Luck, Tony" <tony.luck@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH 12/20] x86, edac: use Intel family name macros for edac driver |
| Date | 2016-06-02 18:20 +0200 |
| Message-ID | <rFDvI-87Q-19@gated-at.bofh.it> (permalink) |
| References | <rFowF-7d9-5@gated-at.bofh.it> <rFowG-7d9-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> Another straightforward replacement of magic numbers. It would be if I hadn't forgotten that INTEL_FAM6_MODEL_BROADWELL_XEON_D had a separate model number from the other Broadwell Xeons when I switched the driver from PCI device lookup to cpu model number. This needs to add an entry for BDX-DE (use the same table initializer). Probably as a separate patch before/after this. -Tony [The name INTEL_FAM6_MODEL_BROADWELL_XEON_D is so long it will spoil the line-up of this code ... +1 vote on Boris' suggestion to drop the "MODEL_" bit from all these names]
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 12/20] x86, edac: use Intel family name macros for edac driver Dave Hansen <dave@sr71.net> - 2016-06-02 02:20 +0200 RE: [PATCH 12/20] x86, edac: use Intel family name macros for edac driver "Luck, Tony" <tony.luck@intel.com> - 2016-06-02 18:20 +0200 RE: [PATCH 12/20] x86, edac: use Intel family name macros for edac driver "Luck, Tony" <tony.luck@intel.com> - 2016-06-02 19:30 +0200
csiph-web