Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1412424

Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function
Date 2016-06-02 18:40 +0200
Message-ID <rFDP4-8ex-21@gated-at.bofh.it> (permalink)
References <rFpsJ-7KE-1@gated-at.bofh.it> <rFqI9-50-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jun 1, 2016 at 7:31 PM, George Spelvin
<linux@sciencehorizons.net> wrote:
>
> I could use two more iterations of HASH_MIX() or something similar,
> then just take the x value, but that's 6 cycles.  If a multiply is
> 4 or 5 cycles, that's a net loss.

Yes. Especially since the multiply will often end up more able to be
run in parallel with other things.

> But worrying about that is the reason I left provision for arch-specific
> hooks, and I'm already working on the first: the PA-RISC doesn't have
> an integer multiplier at all, although the FPU can do 32-bit integer
> multiplies.

Don't worry about pa-risc. There may be a handful of users, where even
"users" is more of a "boot up occasionally just for perverse fun"
rather than anything else.

That's true of at least half the architectures we support - the only
ones that really matter and where performance is a real isseu are
currently x86, arm and powerpc.

                  Linus

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function Linus Torvalds <torvalds@linux-foundation.org> - 2016-06-02 03:20 +0200
  Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function "George Spelvin" <linux@sciencehorizons.net> - 2016-06-02 04:40 +0200
    Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function Linus Torvalds <torvalds@linux-foundation.org> - 2016-06-02 18:40 +0200
      Re: [PATCH v3 06/10] fs/namei.c: Improve dcache hash function "George Spelvin" <linux@sciencehorizons.net> - 2016-06-02 20:30 +0200

csiph-web