Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1412368

Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

From Fabio Estevam <festevam@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision
Date 2016-06-02 17:50 +0200
Message-ID <rFD2G-7GN-11@gated-at.bofh.it> (permalink)
References <rFAeu-5Zh-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Clemens,

On Thu, Jun 2, 2016 at 9:47 AM, Clemens Gruber
<clemens.gruber@pqgruber.com> wrote:
> Instead of checking the SGTL5000 chip revision, we should only check if
> the VDDD regulator exists and only call sgtl5000_replace_vddd_with_ldo
> if the regulator is missing.
> Otherwise, the user reads in the kernel log that the internal LDO is
> used, even though he did follow the NXP recommendation to use external
> VDDD and also specified VDDD-supply in the devicetree.
>
> Also remove the comment, which incorrectly states that external VDDD is
> only supported for SGTL5000 chip revisions < 0x11.
> Official NXP documentation recommends using external VDDD and not the
> internal LDO due to the SGTL5000 erratum ER1. This also applies to
> revisions >= 0x11.
>
> Tested on an i.MX6Q board with SGTL5000 rev 0x11 and external VDDD.

Patch looks good to me.

Eric,

Sometime ago you were looking at this. What do you think about this patch?

Thanks

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Clemens Gruber <clemens.gruber@pqgruber.com> - 2016-06-02 14:50 +0200
  Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Fabio Estevam <festevam@gmail.com> - 2016-06-02 17:50 +0200
    Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Mark Brown <broonie@kernel.org> - 2016-06-02 19:00 +0200
      Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Clemens Gruber <clemens.gruber@pqgruber.com> - 2016-06-03 18:00 +0200
    Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Eric Nelson <eric@nelint.com> - 2016-06-03 18:30 +0200
      Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Eric Nelson <eric@nelint.com> - 2016-06-04 07:20 +0200
        Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Clemens Gruber <clemens.gruber@pqgruber.com> - 2016-06-04 11:10 +0200
          Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not  revision Clemens Gruber <clemens.gruber@pqgruber.com> - 2016-06-06 01:20 +0200
            Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Fabio Estevam <festevam@gmail.com> - 2016-06-06 03:30 +0200
              Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not  revision Clemens Gruber <clemens.gruber@pqgruber.com> - 2016-06-06 18:50 +0200
                Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Fabio Estevam <festevam@gmail.com> - 2016-06-06 19:20 +0200
  Re: [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision Mark Brown <broonie@kernel.org> - 2016-06-06 20:00 +0200

csiph-web