Re: [PATCH v2 0/4] * rtl8712: Replace semaphores with mutex / completions *

From	Larry Finger <Larry.Finger@lwfinger.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/4] * rtl8712: Replace semaphores with mutex / completions *
Date	2016-06-02 17:20 +0200
Message-ID	<rFCzD-7xa-21@gated-at.bofh.it> (permalink)
References	<rFsqB-1dm-5@gated-at.bofh.it> <rFvya-32D-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/02/2016 02:43 AM, Arnd Bergmann wrote:
> On Thursday, June 2, 2016 9:54:06 AM CEST Binoy Jayan wrote:
>> Hi,
>>
>> These are a set of patches [v2] which removes semaphores from:
>>
>> drivers/staging/rtl8712
>>
>> They build correctly (individually and as a whole).
>> NB: I have not tested this as I do not have the following hardware:
>>
>> "RealTek RTL8712U (RTL8192SU) Wireless LAN NIC driver"
>>
>> Rework on comments w.r.t. PATCH v1:
>>
>>   - Removed wrapper functions _wait_completion, _down_sema and _enter_pwrlock
>>   - Updated changelog to explain use of mutex_lock instead of
>>     mutex_lock_interruptible in [PATCH v2 4/4]
>>
>
> All four look great now,
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>


I agree.

Tested-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] *** rtl8712: Replace semaphores with mutex / completions *** Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-02 06:30 +0200
  [PATCH v2 4/4] rtl8712: pwrctrl_priv: Replace semaphore lock with mutex Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-02 06:30 +0200
  [PATCH v2 2/4] rtl8712: Replace semaphore terminate_cmdthread_sema with completion Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-02 06:30 +0200
  Re: [PATCH v2 0/4] *** rtl8712: Replace semaphores with mutex / completions *** Arnd Bergmann <arnd@arndb.de> - 2016-06-02 09:50 +0200
    Re: [PATCH v2 0/4] *** rtl8712: Replace semaphores with mutex /  completions *** Larry Finger <Larry.Finger@lwfinger.net> - 2016-06-02 17:20 +0200

csiph-web