Re: [RFC v2] dma-mapping: Use unsigned long for dma_attrs

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v2] dma-mapping: Use unsigned long for dma_attrs
Date	2016-06-01 10:00 +0200
Message-ID	<rF9ej-5BV-45@gated-at.bofh.it> (permalink)
References	<rEu1r-3HZ-11@gated-at.bofh.it> <rEu1s-3HZ-21@gated-at.bofh.it> <rEVl1-5uA-49@gated-at.bofh.it> <rF72N-4kP-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 01, 2016 at 07:36:42AM +0200, Krzysztof Kozlowski wrote:
> > No really for this patch, but I would much prefer to document them next
> > to the code in the long run.  Also I really think these BIT() macros
> > are a distraction compared to the (1 << N) notation.
> 
> Not much difference to me but maybe plain number:
> ...	0x01u
> ...	0x02u
> ?

I prefer the little bit shifts, but even the explicit values are much
better than the obsfucating macros :)  Anyway, your patch and in the end
all three methods will get the work done.

> > I'd just kill this helper, much easier to simply open code it in the
> > caller.
> 
> Keeping it for now helps reducing the number of changes in the patch.
> The patch will be quite big as it has to replace all the uses atomically.
> 
> I can get rid of the helper in consecutive patch.

Sounds fine.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v2] dma-mapping: Use unsigned long for dma_attrs Christoph Hellwig <hch@infradead.org> - 2016-05-31 19:10 +0200
  Re: [RFC v2] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-01 07:40 +0200
    Re: [RFC v2] dma-mapping: Use unsigned long for dma_attrs Christoph Hellwig <hch@infradead.org> - 2016-06-01 10:00 +0200

csiph-web