Re: [PATCH 1/2] clocksource: Add Oxford Semiconductor RPS Dual Timer

From	Neil Armstrong <narmstrong@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] clocksource: Add Oxford Semiconductor RPS Dual Timer
Date	2016-06-01 10:00 +0200
Message-ID	<rF9ei-5BV-5@gated-at.bofh.it> (permalink)
References	<rEOCR-11o-5@gated-at.bofh.it> <rEOCS-11o-39@gated-at.bofh.it> <rF8rU-5jU-17@gated-at.bofh.it>
Organization	Baylibre

Show all headers | View raw

On 06/01/2016 09:03 AM, Thomas Gleixner wrote:
> On Tue, 31 May 2016, Neil Armstrong wrote:
>> +static int oxnas_rps_timer_shutdown(struct clock_event_device *evt)
>> +{
>> +	struct oxnas_rps_timer *rps =
>> +		container_of(evt, struct oxnas_rps_timer, clkevent);
>> +
>> +	if (!clockevent_state_periodic(evt))
>> +		return 0;
> 
> So if the timer is in oneshot mode, then you just leave it enabled. What's the
> rationale of this?

Indeed, there is no rationale.
Fixed in v2.

>> +
>> +	oxnas_rps_timer_config(rps, 0, 0);
> 
> Thanks,
> 
> 	tglx
> 

Thanks,
Neil

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] clocksource: Add support for Oxford Semiconductor RPS Dual Timer Neil Armstrong <narmstrong@baylibre.com> - 2016-05-31 12:00 +0200
  [PATCH 2/2] dt-bindings: clocksource: Add Add Oxford Semiconductor RPS Timer bindings Neil Armstrong <narmstrong@baylibre.com> - 2016-05-31 12:00 +0200
    Re: [PATCH 2/2] dt-bindings: clocksource: Add Add Oxford  Semiconductor RPS Timer bindings Rob Herring <robh@kernel.org> - 2016-06-03 01:30 +0200
  [PATCH 1/2] clocksource: Add Oxford Semiconductor RPS Dual Timer Neil Armstrong <narmstrong@baylibre.com> - 2016-05-31 12:00 +0200
    Re: [PATCH 1/2] clocksource: Add Oxford Semiconductor RPS Dual  Timer Thomas Gleixner <tglx@linutronix.de> - 2016-06-01 09:10 +0200
      Re: [PATCH 1/2] clocksource: Add Oxford Semiconductor RPS Dual Timer Neil Armstrong <narmstrong@baylibre.com> - 2016-06-01 10:00 +0200

csiph-web