Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1410804

Re: [PATCH 5/8] mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe()

From Julian Calaby <julian.calaby@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 5/8] mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe()
Date 2016-06-01 06:20 +0200
Message-ID <rF5Nn-3uf-5@gated-at.bofh.it> (permalink)
References <rDqMi-4xu-11@gated-at.bofh.it> <rDqMi-4xu-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi All,

On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> It's better to have the device name prefixed in the error message.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

This looks right to me.

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

> ---
>
>  drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 5/8] mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe() Julian Calaby <julian.calaby@gmail.com> - 2016-06-01 06:20 +0200

csiph-web