Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410675

Re: [RFC PATCH] livepatch: allow removal of a disabled patch

Show all headers | View raw

On Tue, 3 May 2016, Miroslav Benes wrote:

> > > Currently we do not allow patch module to unload since there is no
> > > method to determine if a task is still running in the patched code.
> > > 
> > > The consistency model gives us the way because when the patching
> > > finishes we know that all tasks were marked as safe to call a new
> > > patched function. Thus every new call to the function calls the new
> > > patched code and at the same time no task can be somewhere in the old
> > > code, because it had to leave that code to be marked as safe.
> > > 
> > > We can safely let the patch module go after that.
> > 
> > I found this a little confusing because it talks about patching, whereas
> > we really want to remove the patch module after _unpatching_ it.
> 
> You're right. I'll rephrase that.

Now that it's been settled that this way (completion) is the way to go, 
could you please incorporate the feedback (and persumably also add Acks 
from Josh and Jessica) and send me v2?

Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC PATCH] livepatch: allow removal of a disabled patch Jiri Kosina <jikos@kernel.org> - 2016-06-01 01:20 +0200

csiph-web