Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1409250
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Vincent Guittot <vincent.guittot@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | [PATCH v3] sched: fix first task of a task group is attached twice |
| Date | Mon, 30 May 2016 18:00:02 +0200 |
| Message-ID | <rExLI-6b9-9@gated-at.bofh.it> (permalink) |
| References | <rEpuP-YG-45@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/l6w1ianiXZxK6kMVkm0T2HmzzD00sPm8UInO1Zdz70=; b=RSLmOgLBeuT9U4wzjX/rTtEpGjXyuPPRe9yU7MvG7QD/aZgZdfllHDrtZDGs32oXWG H8BRAA7s1zNcmZFDMt8Hd92dIiCwShc/8LoTTgvSDrWZXBtWUu9ididBWqkw4T4JW6tJ HFmaD9Ht1mqISWDd0AxHL1PHw+EOEggoFXEwc= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/l6w1ianiXZxK6kMVkm0T2HmzzD00sPm8UInO1Zdz70=; b=kpFTXgjklurNkxoVvhQtRbvUHUnGLURmiOKuaBH3iVDk7QS8Lw85jAqplGo9kBgKac G20fg9r64bw9Sr3Ah4WRRZgizsTbtNrKCycbSyfAhaw0dj70tgJbiRNBtHSnudsd0L/y AyiksnSHEXZqkNz0M91EznoM9uWIWRmoZeSPn0DLQ1+09YvHgZzJbqGzFNHKDlnZIPjE FJ1TXtgoCQLLa0sch5MKRbn5a/TDep+ukDxjw4Xrx4rx7y/E0JMSFgT8z+J/Owv5YiPS /plr0rCyTPRTHalBEXzSYV8JFRY6PIovD3BYOFVzz2my8zXpXfWCthF7xklm/MnW/GHu IJFQ== |
| X-Gm-Message-State | ALyK8tLxgbl+KX1JuWDhZhUO2aqaelRixex9txi8JxLZk26rX7hAqnbJmwgHLXPCJQRIq6Qf |
| X-Received | by 10.28.185.202 with SMTP id j193mr750136wmf.83.1464623551064; Mon, 30 May 2016 08:52:31 -0700 (PDT) |
| X-Mailer | git-send-email 1.9.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 42 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | yuyang.du@intel.com, dietmar.eggemann@arm.com, Vincent Guittot <vincent.guittot@linaro.org> |
| X-Original-Date | Mon, 30 May 2016 17:52:20 +0200 |
| X-Original-Message-ID | <1464623541-25429-1-git-send-email-vincent.guittot@linaro.org> |
| X-Original-References | <CAKfTPtB_yb0P2FEZ4AKR6+Hjad_7dOxiC_w702RGOV6FnDWR8g@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1409250 |
Show key headers only | View raw
The cfs_rq->avg.last_update_time is initialize to 0 with the main effect that the 1st sched_entity that will be attached, will keep its last_update_time set to 0 and will attached once again during the enqueue. Initialize cfs_rq->avg.last_update_time to 1 instead. Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> --- v3: - add initialization of load_last_update_time_copy for not 64bits system - move init into init_cfs_rq v2: - rq_clock_task(rq_of(cfs_rq)) can't be used because lock is not held kernel/sched/fair.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 218f8e8..86be9c1 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8459,6 +8459,16 @@ void init_cfs_rq(struct cfs_rq *cfs_rq) cfs_rq->min_vruntime_copy = cfs_rq->min_vruntime; #endif #ifdef CONFIG_SMP + /* + * Set last_update_time to something different from 0 to make + * sure the 1st sched_entity will not be attached twice: once + * when attaching the task to the group and one more time when + * enqueueing the task. + */ + cfs_rq->avg.last_update_time = 1; +#ifndef CONFIG_64BIT + cfs_rq->load_last_update_time_copy = 1; +#endif atomic_long_set(&cfs_rq->removed_load_avg, 0); atomic_long_set(&cfs_rq->removed_util_avg, 0); #endif -- 1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-24 15:10 +0200
[PATCH v2] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-25 17:10 +0200
Re: [PATCH v2] sched: fix first task of a task group is attached twice Yuyang Du <yuyang.du@intel.com> - 2016-05-26 08:40 +0200
Re: [PATCH v2] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-26 10:30 +0200
Re: [PATCH v2] sched: fix first task of a task group is attached twice Yuyang Du <yuyang.du@intel.com> - 2016-05-26 10:40 +0200
Re: [PATCH v2] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-26 11:00 +0200
Re: [PATCH v2] sched: fix first task of a task group is attached twice Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-05-27 17:50 +0200
Re: [PATCH v2] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-27 19:20 +0200
Re: [PATCH v2] sched: fix first task of a task group is attached twice Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-05-27 22:40 +0200
Re: [PATCH v2] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-30 09:10 +0200
[PATCH v3] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-30 18:00 +0200
Re: [PATCH v3] sched: fix first task of a task group is attached twice Yuyang Du <yuyang.du@intel.com> - 2016-05-31 05:50 +0200
Re: [PATCH v3] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-31 09:30 +0200
Re: [PATCH v3] sched: fix first task of a task group is attached twice Yuyang Du <yuyang.du@intel.com> - 2016-05-31 10:50 +0200
Re: [PATCH v2] sched: fix first task of a task group is attached twice Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-30 18:00 +0200
csiph-web