[PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails.

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Joao Pinto <Joao.Pinto@synopsys.com>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails.
Date	Mon, 30 May 2016 17:20:02 +0200
Message-ID	<rEx90-5Uj-29@gated-at.bofh.it> (permalink)
References	<rEx90-5Uj-31@gated-at.bofh.it>
X-Mailer	git-send-email 1.8.1.5
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	ijc+devicetree@hellion.org.uk, rmk+kernel@armlinux.org.uk, linux@armlinux.org.uk, liviu.dudau@arm.com, ryan.harkin@linaro.org, Joao Pinto <Joao.Pinto@synopsys.com>
X-Original-Date	Mon, 30 May 2016 16:15:54 +0100
X-Original-Message-ID	<2f242f545c99fc604fb70eeffcfd5d7703ace18d.1464619185.git.jpinto@synopsys.com>
X-Original-References	<cover.1464619185.git.jpinto@synopsys.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1409214

Show key headers only | View raw

When using ffplay to reproduce video+sound it was noticed that sometimes the
sound was disabled. The cause was an initial EDID checksum error that disabled
the HDMI sound. By adding this tweak, it was noticed that the sound is not
even when initial EDID checksum error ocurres.

Signed-off-by: Joao Pinto <jpinto@synopsys.com>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 7020b50..fc7c1c3 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -587,6 +587,17 @@ static void tda998x_detect_work(struct work_struct *work)
 		drm_kms_helper_hotplug_event(dev);
 }
 
+/* handle HDMI connect/disconnect */
+static void tda998x_hpd(struct work_struct *work)
+{
+	struct delayed_work *dwork = to_delayed_work(work);
+	struct tda998x_priv *priv =
+			container_of(dwork, struct tda998x_priv, dwork);
+
+	if (&priv->encoder && priv->encoder.dev)
+		drm_kms_helper_hotplug_event(priv->encoder.dev);
+}
+
 /*
  * only 2 interrupts may occur: screen plug/unplug and EDID read
  */
@@ -1313,6 +1324,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv)
 
 		/* init read EDID waitqueue and HDP work */
 		init_waitqueue_head(&priv->wq_edid);
+		INIT_DELAYED_WORK(&priv->dwork, tda998x_hpd);
 
 		/* clear pending interrupts */
 		reg_read(priv, REG_INT_FLAGS_0);
-- 
1.8.1.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when EDID checksum fails. Joao Pinto <Joao.Pinto@synopsys.com> - 2016-05-30 17:20 +0200
  Re: [PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when  EDID checksum fails. Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-05-30 21:20 +0200

csiph-web