Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c
Date	2016-05-30 16:20 +0200
Message-ID	<rEwcV-5hx-1@gated-at.bofh.it> (permalink)
References	<rDEYV-4Tt-3@gated-at.bofh.it> <rDEYV-4Tt-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> found by the checkpatch.pl tool
> 
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>

The patch looks good :) adding the int makes it more verbose.

Just the same comment as the previous patch, we can see in the diff which file
is affected by this. You can just say:
"This fixes a WARNING: Prefer 'unsigned int' ..."

Thanks,
Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> - 2016-05-28 07:30 +0200
  Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of  unsigned issue in s626.c Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-30 16:20 +0200

csiph-web