[PATCH v1 2/2] lib/uuid.c: use correct offset in uuid parser

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	[PATCH v1 2/2] lib/uuid.c: use correct offset in uuid parser
Date	2016-05-30 16:50 +0200
Message-ID	<rEwFX-5sh-5@gated-at.bofh.it> (permalink)
References	<rEwFX-5sh-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Bjørn Mork <bjorn@mork.no>

Use '+ 0' and '+ 1' as offsets, like they were intended, instead
of adding to the result.

Fixes: 2b1b0d66704a ("lib/uuid.c: introduce a few more generic helpers")
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 lib/uuid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/uuid.c b/lib/uuid.c
index e116ae5..37687af 100644
--- a/lib/uuid.c
+++ b/lib/uuid.c
@@ -106,8 +106,8 @@ static int __uuid_to_bin(const char *uuid, __u8 b[16], const u8 ei[16])
 		return -EINVAL;
 
 	for (i = 0; i < 16; i++) {
-		int hi = hex_to_bin(uuid[si[i]] + 0);
-		int lo = hex_to_bin(uuid[si[i]] + 1);
+		int hi = hex_to_bin(uuid[si[i] + 0]);
+		int lo = hex_to_bin(uuid[si[i] + 1]);
 
 		b[ei[i]] = (hi << 4) | lo;
 	}
-- 
2.8.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v1 2/2] lib/uuid.c: use correct offset in uuid parser Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-30 16:50 +0200

csiph-web