Re: [PATCH 1/5] spi: sunxi: fix transfer timeout

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] spi: sunxi: fix transfer timeout
Date	2016-05-30 11:50 +0200
Message-ID	<rErZE-2oF-23@gated-at.bofh.it> (permalink)
References	<rDfnP-5MI-3@gated-at.bofh.it> <rDfnP-5MI-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, May 26, 2016 at 07:25:23PM -0000, Michal Suchanek wrote:
> The trasfer timeout is fixed at 1000 ms. Reading a 4Mbyte flash over
> 1MHz SPI bus takes way longer than that. Calculate the timeout from the
> actual time the transfer is supposed to take and multiply by 2 for good
> measure.
> 
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> ---
> 
> v2:
> - fix build error
> - use unsigned instead of int in max_t

And this generates warnings in checkpatch. Please make sure that you
run it before submitting any patches.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/5] spi: sunxi: fix transfer timeout Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-30 11:50 +0200

csiph-web