Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1408936

Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

Show all headers | View raw

On 05/30/2016 11:09 AM, Axel Lin wrote:
> Current code for .set_ramp_delay() rounds down the value written to
> register, while the implementation of .set_voltage_time_sel() works on
> original constraints (not rounded down).
> Fix the logic in .set_ramp_delay and also remove unused ret_val variable.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> v2: Update commit log base on Krzysztof's comment.
>  drivers/regulator/max8973-regulator.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)


Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFT][PATCH v2] regulator: max8973: Fix setting ramp delay Axel Lin <axel.lin@ingics.com> - 2016-05-30 11:10 +0200
  Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-30 11:30 +0200
  Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay Laxman Dewangan <ldewangan@nvidia.com> - 2016-05-30 12:50 +0200

csiph-web