Re: [STLinux Kernel] [PATCH 02/11] drivers: clk: st: Add clock propagation for audio clocks

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Gabriel Fernandez <gabriel.fernandez@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [STLinux Kernel] [PATCH 02/11] drivers: clk: st: Add clock propagation for audio clocks
Date	Mon, 30 May 2016 09:40:01 +0200
Message-ID	<rEpXP-18L-1@gated-at.bofh.it> (permalink)
References	<rA5kZ-87e-3@gated-at.bofh.it> <rA5l1-87e-35@gated-at.bofh.it> <rCKN3-3HL-1@gated-at.bofh.it> <rD0f8-4Ml-19@gated-at.bofh.it> <rD2TE-6uy-15@gated-at.bofh.it> <rD3cZ-6Qi-15@gated-at.bofh.it> <rD3wm-6WJ-15@gated-at.bofh.it> <rDknw-rU-19@gated-at.bofh.it> <rDsbn-5gf-3@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CXFdIBn+Pw5WlhcBSJfWOQXPXLTp1/ML+1KbMe3YqIg=; b=b9U6OfuqEWXTTERm5pXmOrjl8yDlyAlpCbIFPx9+9tIxVZWq2KP03Kzh7R7bYdvwJY AfwTkBp8EFUoL0KJhzgBznWC6HLzP6yIb8i6fDMOvbcI7xU6u58ycmom/mp8Rw6MMucb UUiLrh7W5DxieCG2RmXKccY6RGrbRYhcVeyEk=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CXFdIBn+Pw5WlhcBSJfWOQXPXLTp1/ML+1KbMe3YqIg=; b=jAOq4syjvKoTrySy9gJNmDDn7Jf5WWMXMjfJUuxnHQgjshtDkr9y5764X2mUXPrJ/C wQnb7ti6pXhm7Q0hfeqcTUEWxO8vu/A9mjMuQ1dp1muMe7CikO8L0a9dfcuJWLWMtKB9 xB/eKjSeyPi9KsY2vbCBwUmo0Y0wol2vC2rtJrhz9UEVZi0LyhYnKahICwMB5vaxsopa D4xOw9caUrHIREjgs2BCuVfz6vfPmewAUOImIoCXjFB0D58qh1rCB6aVM7bA7lCpddxZ 5fEufOiDDW9IAXeBTd+3vH73vazEcW/aEgRaIBlWMgcaQrrs3t+CJIrnpc4ySVl52mfr 2ZOA==
X-Gm-Message-State	ALyK8tLdFY3Y4Pn4ruTUhWucne+3g72eBWODUH0lNpvBlAm3+StA9CJ17ykLyl+JjHoAclyHWpWGQNQ1+t1nC04l
X-Received	by 10.194.119.195 with SMTP id kw3mr24931143wjb.166.1464593446129; Mon, 30 May 2016 00:30:46 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	67
Organization	linux.* mail to news gateway
X-Original-Cc	loic pallardy <loic.pallardy@st.com>, Mark Rutland <mark.rutland@arm.com>, "kernel@stlinux.com" <kernel@stlinux.com>, Geert Uytterhoeven <geert+renesas@glider.be>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andrzej Hajda <a.hajda@samsung.com>, linux-clk <linux-clk@vger.kernel.org>, Benjamin GAIGNARD <benjamin.gaignard@st.com>, Olivier Bideau <olivier.bideau@st.com>, Russell King <linux@armlinux.org.uk>, Thierry Reding <treding@nvidia.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Vincent ABRIOU <vincent.abriou@st.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Srinivas Kandagatla <srinivas.kandagatla@gmail.com>, Stephen Boyd <sboyd@codeaurora.org>, Kumar Gala <galak@codeaurora.org>, Dinh Nguyen <dinguyen@opensource.altera.com>
X-Original-Date	Mon, 30 May 2016 09:30:06 +0200
X-Original-Message-ID	<CAG374jBTLDiXHQVuxKMA2-xZr1yHUBLmSdT2HAZhp16dTsQDoQ@mail.gmail.com>
X-Original-References	<1463560892-7209-1-git-send-email-gabriel.fernandez@linaro.org> <1463560892-7209-3-git-send-email-gabriel.fernandez@linaro.org> <20160525172409.GA27913@rob-hp-laptop> <CAG374jDTCJfZB+PuAnggjXhbcd3NjJqrESpe_EnMniCAeoph9A@mail.gmail.com> <CAL_JsqLOG4P0H+HkQ3mJhfibatuV2T51KqOn-+U+LK8WUx7QgA@mail.gmail.com> <5746F486.602@st.com> <CAL_JsqLeD8uTmMYLFZ5Sh9=JV5s1xthvruXL-W=c=zcVS=G-ZA@mail.gmail.com> <5747F5E8.5030300@st.com> <20160527154159.GA17818@rob-hp-laptop>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1408821

Show key headers only | View raw

On 27 May 2016 at 17:41, Rob Herring <robh@kernel.org> wrote:
> On Fri, May 27, 2016 at 09:23:20AM +0200, loic pallardy wrote:
>>
>>
>> On 05/26/2016 03:20 PM, Rob Herring wrote:
>> >On Thu, May 26, 2016 at 8:05 AM, loic pallardy <loic.pallardy@st.com> wrote:
>> >>
>> >>
>> >>On 05/26/2016 02:46 PM, Rob Herring wrote:
>> >>>
>> >>>On Thu, May 26, 2016 at 4:49 AM, Gabriel Fernandez
>> >>><gabriel.fernandez@linaro.org> wrote:
>> >>>>
>> >>>>On 25 May 2016 at 19:24, Rob Herring <robh@kernel.org> wrote:
>> >>>>>
>> >>>>>
>> >>>>>On Wed, May 18, 2016 at 10:41:23AM +0200, Gabriel Fernandez wrote:
>> >>>>>>
>> >>>>>>This patch allows fine tuning of the quads FS for audio clocks
>> >>>>>>accuracy.
>> >>>>>>
>
>> >>>
>> >>>That is no different and suffers the same point I raised. It requires
>> >>>updating the DT for any clock configuration change or enhancement.
>> >>>
>> >>Agree with you, DT update is needed as soon as a clock configuration should
>> >>be changed. This is due to STiH clock driver design based on DT description
>> >>of SoC clock tree.
>> >>
>> >>This clock driver was accepted 2 years ago. At the time being there was
>> >>discussion about clock tree description location: driver or DT.
>> >>Bad choice was done for this driver...
>> >>
>> >>If we decide to redesign STiH clock driver using in-driver clock tree
>> >>description, this will modify STiH clock DT nodes description and so break
>> >>DT backward compatibility.
>> >>
>> >>What's from your pov the best option?
>> >
>> >You can break it once or every time you need a clock change. I'd go
>> >with the former. Maybe more specific compatible strings throughout
>> >alone would be enough rather than a flag day changing the binding.
>>
>> So if I understand you correctly, main issue is d0 and d2 signification.
>> d0 and d2 are indeed location of the flexgen in the SoC. But that's right
>> flexgen are dedicated to clocks generation for features (system, audio,
>> video).
>> What about "st,flexgen-audio" and "st,flexgen-video"?
>
> It is not so much the name of these 2, but whether there are other cases
> for different clock nodes that could need the same thing. If so, update
> them all now rather than 1 by 1.
>
> Rob

Hi Rob,
Ok i will send a V2 for that.

Mike,
the first patch "drivers: clk: st: Add fs660c32 synthesizer algorithm"  can
be taken into account regardless the remark of Rob. Can you have a look ?

Thanks.
Best Regards

Gabriel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 02/11] drivers: clk: st: Add clock propagation for audio clocks Gabriel Fernandez <gabriel.fernandez@linaro.org> - 2016-05-18 10:50 +0200
  Re: [PATCH 02/11] drivers: clk: st: Add clock propagation for audio  clocks Rob Herring <robh@kernel.org> - 2016-05-25 19:30 +0200
    Re: [PATCH 02/11] drivers: clk: st: Add clock propagation for audio clocks Gabriel Fernandez <gabriel.fernandez@linaro.org> - 2016-05-26 12:00 +0200
      Re: [PATCH 02/11] drivers: clk: st: Add clock propagation for audio clocks Rob Herring <robh@kernel.org> - 2016-05-26 14:50 +0200
        Re: [STLinux Kernel] [PATCH 02/11] drivers: clk: st: Add clock  propagation for audio clocks loic pallardy <loic.pallardy@st.com> - 2016-05-26 15:10 +0200
          Re: [STLinux Kernel] [PATCH 02/11] drivers: clk: st: Add clock  propagation for audio clocks Rob Herring <robh@kernel.org> - 2016-05-26 15:30 +0200
            Re: [STLinux Kernel] [PATCH 02/11] drivers: clk: st: Add clock  propagation for audio clocks loic pallardy <loic.pallardy@st.com> - 2016-05-27 09:30 +0200
              Re: [STLinux Kernel] [PATCH 02/11] drivers: clk: st: Add clock  propagation for audio clocks Rob Herring <robh@kernel.org> - 2016-05-27 17:50 +0200
                Re: [STLinux Kernel] [PATCH 02/11] drivers: clk: st: Add clock  propagation for audio clocks Gabriel Fernandez <gabriel.fernandez@linaro.org> - 2016-05-30 09:40 +0200

csiph-web