Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1408738

[PATCH v6 06/11 1 update 2/2] perf tools: Extract common API out of unwind-libunwind-local.c

From He Kuang <hekuang@huawei.com>
Newsgroups linux.kernel
Subject [PATCH v6 06/11 1 update 2/2] perf tools: Extract common API out of unwind-libunwind-local.c
Date 2016-05-30 05:30 +0200
Message-ID <rEm3T-73G-25@gated-at.bofh.it> (permalink)
References <rDLnH-nQ-7@gated-at.bofh.it> <rEm3T-73G-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


This patch extracts common unwind-libunwind APIs out of
unwind-libunwind-local.c, this part will be used by both local and
remote libunwind.

Signed-off-by: He Kuang <hekuang@huawei.com>
---
 tools/perf/util/Build                    |  1 +
 tools/perf/util/unwind-libunwind-local.c | 32 ------------------------------
 tools/perf/util/unwind-libunwind.c       | 34 ++++++++++++++++++++++++++++++++
 3 files changed, 35 insertions(+), 32 deletions(-)
 create mode 100644 tools/perf/util/unwind-libunwind.c

diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index 5e23d85..004fb1d 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -100,6 +100,7 @@ libperf-$(CONFIG_DWARF) += dwarf-aux.o
 
 libperf-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
 libperf-$(CONFIG_LOCAL_LIBUNWIND)    += unwind-libunwind-local.o
+libperf-$(CONFIG_LIBUNWIND)          += unwind-libunwind.o
 
 libperf-$(CONFIG_LIBBABELTRACE) += data-convert-bt.o
 
diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
index 93d2d8e..37e53f8 100644
--- a/tools/perf/util/unwind-libunwind-local.c
+++ b/tools/perf/util/unwind-libunwind-local.c
@@ -692,35 +692,3 @@ void register_local_unwind_libunwind_ops(struct thread *thread)
 {
 	thread->unwind_libunwind_ops = &_unwind_libunwind_ops;
 }
-
-int unwind__prepare_access(struct thread *thread)
-{
-	register_local_unwind_libunwind_ops(thread);
-
-	return thread->unwind_libunwind_ops->prepare_access(thread);
-}
-
-void unwind__flush_access(struct thread *thread)
-{
-	if (thread->unwind_libunwind_ops)
-		thread->unwind_libunwind_ops->flush_access(thread);
-}
-
-void unwind__finish_access(struct thread *thread)
-{
-	if (thread->unwind_libunwind_ops)
-		thread->unwind_libunwind_ops->finish_access(thread);
-}
-
-int unwind__get_entries(unwind_entry_cb_t cb, void *arg,
-			 struct thread *thread,
-			 struct perf_sample *data, int max_stack)
-{
-	if (thread->unwind_libunwind_ops)
-		return thread->unwind_libunwind_ops->get_entries(cb, arg,
-								 thread,
-								 data,
-								 max_stack);
-	else
-		return 0;
-}
diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
new file mode 100644
index 0000000..40d0453
--- /dev/null
+++ b/tools/perf/util/unwind-libunwind.c
@@ -0,0 +1,34 @@
+#include "unwind.h"
+#include "thread.h"
+
+int unwind__prepare_access(struct thread *thread)
+{
+	register_local_unwind_libunwind_ops(thread);
+
+	return thread->unwind_libunwind_ops->prepare_access(thread);
+}
+
+void unwind__flush_access(struct thread *thread)
+{
+	if (thread->unwind_libunwind_ops)
+		thread->unwind_libunwind_ops->flush_access(thread);
+}
+
+void unwind__finish_access(struct thread *thread)
+{
+	if (thread->unwind_libunwind_ops)
+		thread->unwind_libunwind_ops->finish_access(thread);
+}
+
+int unwind__get_entries(unwind_entry_cb_t cb, void *arg,
+			 struct thread *thread,
+			 struct perf_sample *data, int max_stack)
+{
+	if (thread->unwind_libunwind_ops)
+		return thread->unwind_libunwind_ops->get_entries(cb, arg,
+								 thread,
+								 data,
+								 max_stack);
+	else
+		return 0;
+}
-- 
1.8.5.2

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6 00/11] Add support for remote unwind He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200
  [PATCH v6 11/11] perf callchain: Support aarch64 cross-platform He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200
  [PATCH v6 04/11] perf tools: Move unwind__prepare_access from thread_new into thread__insert_map He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200
    Re: [PATCH v6 04/11] perf tools: Move unwind__prepare_access from  thread_new into thread__insert_map Jiri Olsa <jolsa@redhat.com> - 2016-05-30 11:00 +0200
  [PATCH v6 03/11] perf tools: Introducing struct unwind_libunwind_ops for local unwind He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200
    Re: [PATCH v6 03/11] perf tools: Introducing struct  unwind_libunwind_ops for local unwind Jiri Olsa <jolsa@redhat.com> - 2016-05-30 11:00 +0200
  [PATCH v6 08/11] perf tools: Show warnings for unsupported cross-platform unwind He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200
    Re: [PATCH v6 08/11] perf tools: Show warnings for unsupported  cross-platform unwind Jiri Olsa <jolsa@redhat.com> - 2016-05-30 11:00 +0200
  [PATCH v6 01/11] perf tools: Use LIBUNWIND_DIR for remote libunwind feature check He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200
  [PATCH v6 06/11] perf tools: Extract local libunwind code out of unwind-libunwind.c He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200
    Re: [PATCH v6 06/11] perf tools: Extract local libunwind code out of  unwind-libunwind.c "Wangnan (F)" <wangnan0@huawei.com> - 2016-05-28 14:20 +0200
      [PATCH v6 06/11 1 update 1/2] perf tools: Rename unwind-libunwind.c to unwind-libunwind-local.c He Kuang <hekuang@huawei.com> - 2016-05-30 05:30 +0200
        [PATCH v6 06/11 1 update 2/2] perf tools: Extract common API out of unwind-libunwind-local.c He Kuang <hekuang@huawei.com> - 2016-05-30 05:30 +0200
      Re: [PATCH v6 06/11] perf tools: Extract local libunwind code out of  unwind-libunwind.c Hekuang <hekuang@huawei.com> - 2016-05-30 05:30 +0200
  [PATCH v6 02/11] perf tools: Decouple thread->address_space on libunwind He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200
  [PATCH v6 07/11] perf tools: Export normalize_arch() function He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200
  [PATCH v6 09/11] perf tools: Change fixed name of libunwind__arch_reg_id to macro He Kuang <hekuang@huawei.com> - 2016-05-28 14:10 +0200

csiph-web