[RFC][PATCH 0/2] Fix for settimeofday() error checking regression

From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	[RFC][PATCH 0/2] Fix for settimeofday() error checking regression
Date	2016-05-31 23:40 +0200
Message-ID	<rEZyh-7VD-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

As reported by Mika Westerberg here:
	https://lkml.org/lkml/2016/5/30/413

A regression in the settimeofday error checking snuck in via
86d3473224b0 ("time: Introduce do_sys_settimeofday64()"),
effecting cases where the timeval is null but the timezone
was set.

This patchset contains my proposed fix and an addition to
the kselftests to add checks for this case.

Testing/feedback would be greatly appreciated!

thanks
-john

Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Baolin Wang <baolin.wang@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Prarit Bhargava <prarit@redhat.com>


John Stultz (2):
  time: Fix problematic change in settimeofday error checking
  kselftests: timers: Add set-tz test case

 include/linux/timekeeping.h             |   3 +
 tools/testing/selftests/timers/Makefile |   3 +-
 tools/testing/selftests/timers/set-tz.c | 119 ++++++++++++++++++++++++++++++++
 3 files changed, 124 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/timers/set-tz.c

-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 0/2] Fix for settimeofday() error checking regression John Stultz <john.stultz@linaro.org> - 2016-05-31 23:40 +0200
  [RFC][PATCH 1/2] time: Fix problematic change in settimeofday error checking John Stultz <john.stultz@linaro.org> - 2016-05-31 23:40 +0200
    Re: [RFC][PATCH 1/2] time: Fix problematic change in settimeofday  error checking Dima Stepanov <dstepanov.src@gmail.com> - 2016-06-01 04:20 +0200
    Re: [RFC][PATCH 1/2] time: Fix problematic change in settimeofday  error checking Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-01 12:50 +0200
  [RFC][PATCH 2/2] kselftests: timers: Add set-tz test case John Stultz <john.stultz@linaro.org> - 2016-05-31 23:40 +0200

csiph-web