Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1410624

Re: [PATCH] mm/swap: lru drain on memory reclaim workqueue

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mm/swap: lru drain on memory reclaim workqueue
Date 2016-05-31 23:10 +0200
Message-ID <rEZ5f-7LR-5@gated-at.bofh.it> (permalink)
References <rEYVA-7tn-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, May 31, 2016 at 02:50:15PM -0600, Keith Busch wrote:
> +	system_mem_wq = alloc_workqueue("events_mem_unbound", WQ_UNBOUND | WQ_MEM_RECLAIM,

So, WQ_MEM_RECLAIM on a shared workqueue doesn't make much sense.
That flag guarantees single concurrency level to the workqueue.  How
would multiple users of a shared workqueue coordinate around that?
What prevents one events_mem_unbound user from depending on, say,
draining lru?  If lru draining requires a rescuer to guarantee forward
progress under memory pressure, that rescuer worker must be dedicated
for that purpose and can't be shared.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mm/swap: lru drain on memory reclaim workqueue Keith Busch <keith.busch@intel.com> - 2016-05-31 23:00 +0200
  Re: [PATCH] mm/swap: lru drain on memory reclaim workqueue Tejun Heo <tj@kernel.org> - 2016-05-31 23:10 +0200
    Re: [PATCH] mm/swap: lru drain on memory reclaim workqueue Keith Busch <keith.busch@intel.com> - 2016-05-31 23:10 +0200

csiph-web