Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1410627
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] staging: iio: accel: add error check |
| Date | 2016-05-31 23:10 +0200 |
| Message-ID | <rEZ5f-7LR-1@gated-at.bofh.it> (permalink) |
| References | <rEZ5f-7LR-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Go to error_ret if sca3000_read_ctrl_reg() failed. Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> --- Noticed this while inspecting the code for the 1/2 patch. Thanks, Luis drivers/staging/iio/accel/sca3000_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c index ec12181..b3f6dbf 100644 --- a/drivers/staging/iio/accel/sca3000_core.c +++ b/drivers/staging/iio/accel/sca3000_core.c @@ -1046,6 +1046,8 @@ static int sca3000_clean_setup(struct sca3000_state *st) /* Disable ring buffer */ ret = sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL); + if (ret < 0) + goto error_ret; ret = sca3000_write_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL, (ret & SCA3000_OUT_CTRL_PROT_MASK) | SCA3000_OUT_CTRL_BUF_X_EN -- 2.5.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] staging: iio: accel: fix error check Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-31 23:10 +0200 [PATCH 2/2] staging: iio: accel: add error check Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-31 23:10 +0200 Re: [PATCH 1/2] staging: iio: accel: fix error check Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-05-31 23:20 +0200
csiph-web