Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1410519

Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API

From "George G. Davis" <george_davis@mentor.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API
Date 2016-05-31 20:30 +0200
Message-ID <rEWAp-6bM-7@gated-at.bofh.it> (permalink)
References <rEVuG-5z8-13@gated-at.bofh.it> <rEVEn-5CE-49@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello Fabio,

On Tue, May 31, 2016 at 02:26:54PM -0300, Fabio Estevam wrote:
> On Tue, May 31, 2016 at 2:17 PM, George G. Davis
> <george_davis@mentor.com> wrote:
> > Convert the i.MX FEC driver and DT files to use the GPIOD API
> > which automatically handles GPIO polarity.
> >
> > Signed-off-by: George G. Davis <george_davis@mentor.com>
> 
> In order to avoid breaking old dtb's a property called
> 'phy-reset-active-high' has been introduced.
> 
> Check: 962d8cdc3133435a ("net: fec: Rename "phy-reset-active-low"
> property") and 64f10f6ebf5a6d3ae ("net: fec: Add
> "phy-reset-active-low" property to DT").

The GPIOD API handles GPIO active assertion levels as defined by the 
DT binding. So the phy-reset-active-high and/or phy-reset-active-low
property is not needed when using the GPIOD API - just define
GPIO_ACTIVE_LOW or GPIO_ACTIVE_HIGH as required for the board and the
GPIOD API will handle active assert/deassert level as needed.

-- 
Regards,
George

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API "George G. Davis" <george_davis@mentor.com> - 2016-05-31 19:20 +0200
  Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API Fabio Estevam <festevam@gmail.com> - 2016-05-31 19:30 +0200
    Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-05-31 20:30 +0200
      Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API "George G. Davis" <george_davis@mentor.com> - 2016-05-31 20:40 +0200
    Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API "George G. Davis" <george_davis@mentor.com> - 2016-05-31 20:30 +0200
  Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-05-31 19:50 +0200

csiph-web