Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410336

Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer

Show all headers | View raw

On Tue, May 31, 2016 at 03:09:13PM +0200, Gerd Hoffmann wrote:
> On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote:
> 
> > Why store it in the fb and not eg. the plane state?
> 
> Well, drm_plane_state is allocated by drm_atomic_helper_update_plane.
> 
> When sticking the hotspot into the the plane state we have to add hot_x
> and hot_y parameters to drm_plane_funcs->update_plane() and cause quite
> some churn all over the drm tree.
> 
> Or create a separate code path for cursor updates which uses a special
> drm_atomic_helper_update_plane version, which doesn't look very
> attractive too due to code duplication.
> 
> Sticking it into the drm_framebuffer instead looks like a reasonable
> alternative.
> 
> I'm open to better suggestions.

Hmm. Too many layers. I guess this is the easiest solution then. I was
hoping to avoid fattening the fb for something so rarely used, but I
guess there's no sane way to achieve that.

-- 
Ville Syrjälä
Intel OTC

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] add cursor hotspot to drm_framebuffer Gerd Hoffmann <kraxel@redhat.com> - 2016-05-31 13:00 +0200
  Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Daniel Vetter <daniel@ffwll.ch> - 2016-05-31 13:00 +0200
  Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-05-31 14:40 +0200
    Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Gerd Hoffmann <kraxel@redhat.com> - 2016-05-31 15:10 +0200
      Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-05-31 16:00 +0200

csiph-web